Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

properly fail the "Test Suite" check when any inputs are failing #61

Merged
merged 1 commit into from
Aug 12, 2024

Conversation

evgeni
Copy link
Member

@evgeni evgeni commented Aug 12, 2024

No description provided.

Copy link
Member

@ekohl ekohl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Verified in voxpupuli/puppet-example#69. We should also cherry pick it to v2 which we still use in a lot of places.

@ekohl ekohl added the bug Something isn't working label Aug 12, 2024
@ekohl ekohl merged commit 4e7257a into voxpupuli:v3 Aug 12, 2024
@evgeni evgeni deleted the proper-failure branch August 12, 2024 12:43
@ekohl
Copy link
Member

ekohl commented Aug 12, 2024

For the record, https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/collaborating-on-repositories-with-code-quality-features/troubleshooting-required-status-checks#handling-skipped-but-required-checks documents the behavior we were seeing:

When a job fails, any jobs that depend on the failed job are skipped and do not report a failure. A pull request that requires the check may not be blocked. To use a required check on a job that depends on other jobs, use the always() conditional expression in addition to needs, see "Using jobs in a workflow."

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants