Fix CONTRIBUTING documentation #697
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Several arguments no longer work. Despite looking like a warning, bundler will still try to use the system path. ``` $ bundle install --path .vendor/ --without development system_tests release --jobs "$(nproc)" [DEPRECATED] The `--path` flag is deprecated because it relies on being remembered across bundler invocations, which bundler will no longer do in future versions. Instead please use `bundle config set --local path '.vendor/'`, and stop using this flag [DEPRECATED] The `--without` flag is deprecated because it relies on being remembered across bundler invocations, which bundler will no longer do in future versions. Instead please use `bundle config set --local without 'development system_tests release'`, and stop using this flag Bundler 2.4.10 is running, but your lockfile was generated with 2.3.26. Installing Bundler 2.3.26 and restarting using that version. ```
Running the rspec tests require first running the `spec_prep` rake command. This wasn't documented. An argument can be made for it being 'common knowledge', but that goes out the window with the 'all in one solution' for using bundler.
stevenpost
force-pushed
the
bundler_update
branch
from
968366b to
901c9e8
Compare
|
@stevenpost thanks for the PR! The file is actually rendered from a template: https://github.com/voxpupuli/modulesync_config/blob/master/moduleroot/.github/CONTRIBUTING.md.erb could you please send the PR to the template? |
I'll have a look, will reference it here and then close this PR. |
|
Superseeded by voxpupuli/modulesync_config#881 git format-patch master..
sed -i 's;\.github/CONTRIBUTING.md;moduleroot/.github/CONTRIBUTING.md.erb;g' 000*
cd ../modulesync_config
git am ../puppet-mongodb/000* |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR updates the
CONTRIBUTING.mdfile so given commands are actually valid and tests can be run.The bundler commands given contained deprecated arguments that no longer worked.