add server/location_acl argument #1491
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
use include directive to include server/location ACL file from nginx_conf_dir/conf.d/ dir to not repeat allow/deny lists for every location server/location block
nginx::resource::location is a typethat may have no external impact to Forge modules. nginx::resource::server is a typethat may have no external impact to Forge modules. This module is declared in 9 of 578 indexed public
|
|
ping |
1 similar comment
|
ping |
root-expert
requested changes
Apr 1, 2022
| @@ -269,6 +271,7 @@ | |||
| Optional[Enum['any', 'all']] $location_satisfy = undef, | |||
| Optional[Array] $location_allow = undef, | |||
| Optional[Array] $location_deny = undef, | |||
| Optional[String] $location_acl = undef, | |||
There was a problem hiding this comment.
I suppose the name can't be an empty string
Suggested change
| Optional[String] $location_acl = undef, | |
| Optional[String[1]] $location_acl = undef, |
Also maybe the user must be able to overwrite the default path nginx::conf_dir/conf.d ?
| @@ -290,8 +294,10 @@ | |||
| Variant[Array[Stdlib::Absolutepath], Stdlib::Absolutepath] $listen_unix_socket = '/var/run/nginx.sock', | |||
| Optional[String] $listen_unix_socket_options = undef, | |||
| Optional[Enum['any', 'all']] $location_satisfy = undef, | |||
| Optional[String] $server_acl = undef, | |||
There was a problem hiding this comment.
Same here:
Suggested change
| Optional[String] $server_acl = undef, | |
| Optional[String[1]] $server_acl = undef, |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request (PR) description
conf.d/name.aclACLs to server/location blocks to not repeatallow/denyrules multiple times.aclfile) withallow/denyrules in specific block (denyrule will be the last)