test different NodeJS versions using beaker_facter #490
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bastelfreak
approved these changes
Oct 30, 2023
evgeni
commented
Oct 30, 2023
| with: | ||
| pidfile_workaround: 'false' | ||
| beaker_facter: 'nodejs_version:NodeJS:16,18,20' |
There was a problem hiding this comment.
Technically, NodeJS 16 is EOL but it's the only version that is supported on EL7 by nodesource 🤷♀️
evgeni
force-pushed
the
more-tests
branch
5 times, most recently
from
e1ce42e
to
e844801
Compare
evgeni
commented
Oct 30, 2023
| @@ -10,6 +10,8 @@ | |||
| pkg_cmd = 'dpkg -s nodejs | grep "^Maintainer"' | |||
| end | |||
|
|
|||
| nodejs_version = ENV.fetch('BEAKER_FACTER_nodejs_version', '20') | |||
There was a problem hiding this comment.
for some reason, I couldn't use fact('nodejs_version') here
bastelfreak
approved these changes
Oct 30, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request (PR) description
This Pull Request (PR) fixes the following issues