Support rich datatypes and deferred password values

[traylenator]

Pull Request (PR) description

Process the configuration file redis.conf template twice if some of the templates values are deferred.

Currently with deferred values the resulting deferred template cannot be processed since it contains
complex datatypes from stdlib in particular.

This is a redis specific solution that may arrive generally one day in puppetlabs/puppetlabs-stdlib#1425

This Pull Request (PR) fixes the following issues

Fixes #513

[ekohl]

It would be nice to have some sort of test for this. Looking at the rspec-puppet source it should support Deferred.

And taking a step back, this feels like Sensitive where EPP itself should take care of it.

[traylenator]

Tests fail for unrelated reason - resolved in #516

[traylenator]

It would be nice to have some sort of test for this. Looking at the rspec-puppet source it should support Deferred.

Could not see anyway to do something along the lines of:

describe 'with parameter requirepass resolved from a Deferred' do
  let(:params) do
    {
      requirepass: Deferred('sprintf',['%s', '_VALUE_']),
    }
  end

  it {
    is_expected.to contain_file(config_file_orig).with(
      'content' => sensitive(%r{requirepass.*_VALUE_})
    )
  }
end

And taking a step back, this feels like Sensitive where EPP itself should take care of it.

Not sure I follow. We already test that if requirepass is Sensitive that the content of resulting config file is also marked Sensitive.

[ekohl]

Not sure I follow. We already test that if requirepass is Sensitive that the content of resulting config file is also marked Sensitive.

I was suggesting that Puppet itself should take care of this, just like it can unwrap sensitive. Pushing that responsibility to modules is likely to cause problem somewhere.

Of course it doesn't hold this PR back, maybe more ranting.

[traylenator]

CentOS 9 is a timeout.