Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

リリースワークフローから workflow_dispatch を削除 #1359

Merged
merged 1 commit into from
Aug 14, 2023

Conversation

@changeset-bot
Copy link

changeset-bot bot commented Aug 14, 2023

⚠️ No Changeset found

Latest commit: 9fe74b4

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@netlify
Copy link

netlify bot commented Aug 14, 2023

Deploy Preview for ingred-ui ready!

Name Link
🔨 Latest commit 9fe74b4
🔍 Latest deploy log https://app.netlify.com/sites/ingred-ui/deploys/64d97a081e794a0008712c5b
😎 Deploy Preview https://deploy-preview-1359--ingred-ui.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@takurinton
Copy link
Contributor Author

takurinton commented Aug 14, 2023

誰が PR 作ったかどうかで changeset status 実行するか決めてるけど、もしかしたら src 配下に変更が入ったときにだけ走らせればいいかも

changesets がパッケージに影響を与えるかどうかよしなに判断してくれてるから不要

@takurinton
Copy link
Contributor Author

ここらへんを参考
https://github.com/changesets/action#with-publishing

Copy link
Contributor

@ryokosuge ryokosuge left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@takurinton takurinton merged commit f1dae04 into master Aug 14, 2023
1 check passed
@takurinton takurinton deleted the remove-workflow-dispatch branch August 14, 2023 00:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants