Replace VM2 with isolated-vm #8
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@techcoderx Can you pull from master & resolve merge conflicts? |
|
Done, please double check to make sure all the latest methods are being passed in correctly. |
this is required for async functions to work
vaultec81
requested changes
Oct 12, 2023
| stateMerkle = state.finish().stateMerkle | ||
| }) | ||
| const compiled = await isolate.compileScript(code) | ||
| await compiled.run(context) |
There was a problem hiding this comment.
await compiled.run(context) Stalls and fails to execute
|
Apologies for the delay. Missed a few commas in the template which was why it did not compile. |
vaultec81
approved these changes
Nov 2, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Due to patriksimek/vm2#533, the execution engine will have to be replaced with isolated-vm.
The replacement package allows for setting a memory limit (in MB). This may be useful to define a "memory limit" on a transaction basis to calculate a max tx fee for contract calls.
Tested working on my node so far with some contract calls.