Fix dependency issue when using encrypted PVCs for VSHNPostgreSQL #236
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TheBigLee
requested review from
a team,
Kidswiss,
wejdross and
zugao
and removed request for
a team
3 tasks
There was a dependency loop that prevented the creation of VSHNPostgreSQL instances that use encrypted PVCs: * The SGCluster object can't be created before the luks secret for the PVC is generated * The luks secret can't be created without getting the instance count of the cluster object This has been resolved by relying on the instance count from the composite and also waiting for the luks secrets to be present before attempting to access the sgcluster object to be able to override the storageClass for the PVCs Signed-off-by: Nicolas Bigler <nicolas.bigler@vshn.ch>
TheBigLee
force-pushed
the
fix/psql_encrypted_disk
branch
from
154b83d to
2d6b9df
Compare
wejdross
approved these changes
Sep 26, 2024
Kidswiss
approved these changes
Sep 27, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
There was a dependency loop that prevented the creation of VSHNPostgreSQL instances that use encrypted PVCs:
This has been resolved by relying on the instance count from the composite and also waiting for the luks secrets to be present before attempting to access the sgcluster object to be able to override the storageClass for the PVCs
Checklist
bug,enhancement,documentation,change,breaking,dependencyas they show up in the changelog