Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add MariaDB Scaling #249

Merged
merged 1 commit into from
Nov 4, 2024
Merged

Add MariaDB Scaling #249

merged 1 commit into from
Nov 4, 2024

Conversation

Kidswiss
Copy link
Contributor

@Kidswiss Kidswiss commented Oct 25, 2024

Summary

With this MariaDB can scale to a 3 node Galera cluster.

  • Added ProxySQl statefulset
  • Updated default version of MariaDB
  • Updated Galera helm chart
  • Added sensible PDBs to ProxySQL

Checklist

  • Categorize the PR by setting a good title and adding one of the labels:
    bug, enhancement, documentation, change, breaking, dependency
    as they show up in the changelog
  • Update tests.
  • Link this PR to related issues.

@Kidswiss Kidswiss added the minor label Oct 25, 2024
@Kidswiss Kidswiss force-pushed the add/mariadb_scaling branch 11 times, most recently from 0ad1adb to 9dd4654 Compare October 31, 2024 12:02
@Kidswiss Kidswiss requested review from a team, TheBigLee, wejdross and zugao and removed request for a team October 31, 2024 14:26
@Kidswiss Kidswiss force-pushed the add/mariadb_scaling branch 3 times, most recently from edf4bb5 to a318eeb Compare November 1, 2024 07:40
Copy link
Collaborator

@zugao zugao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

The ProxySQL settings will be managed in a different PR right?

apis/vshn/v1/dbaas_vshn_mariadb.go Outdated Show resolved Hide resolved
@Kidswiss Kidswiss force-pushed the add/mariadb_scaling branch from ad3fab8 to 03e7177 Compare November 1, 2024 08:50
@Kidswiss
Copy link
Contributor Author

Kidswiss commented Nov 1, 2024

LGTM

The ProxySQL settings will be managed in a different PR right?

Do you mean the POC with the mysql client? Because right now all the settings are managed, just via the config file.

@zugao
Copy link
Collaborator

zugao commented Nov 1, 2024

Do you mean the POC with the mysql client? Because right now all the settings are managed, just via the config file.

Ah yes, we agreed to first start with config file, all good.

@Kidswiss Kidswiss force-pushed the add/mariadb_scaling branch from 859b637 to 549c2fd Compare November 1, 2024 10:39
@Kidswiss Kidswiss force-pushed the add/mariadb_scaling branch from 549c2fd to 7270acd Compare November 1, 2024 12:39
@Kidswiss Kidswiss requested a review from wejdross November 1, 2024 12:39
@Kidswiss Kidswiss requested a review from zugao November 1, 2024 12:39
@Kidswiss Kidswiss force-pushed the add/mariadb_scaling branch from 7270acd to af8517d Compare November 1, 2024 12:58
@Kidswiss Kidswiss force-pushed the add/mariadb_scaling branch from af8517d to 35a6010 Compare November 1, 2024 13:47
With this MariaDB can scale to a 3 node Galera cluster.

* Added ProxySQl statefulset
* Updated default version of MariaDB
* Updated Galera helm chart
* Added sensible PDBs to ProxySQL
@Kidswiss Kidswiss force-pushed the add/mariadb_scaling branch from 35a6010 to ce970f3 Compare November 1, 2024 13:54
Copy link
Collaborator

@zugao zugao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Kidswiss Kidswiss merged commit ca65196 into master Nov 4, 2024
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants