Create AddOn API #280
Draft
Create AddOn API #280
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
3 tasks
zugao
force-pushed
the
id-addon-billing
branch
from
66071cf to
3b810e6
Compare
zugao
requested review from
a team,
Kidswiss,
TheBigLee and
wejdross
and removed request for
a team
|
Can You explain this PR better? How is that going to help with billing? Why introducing Addons? - To generate prometheus rule based on that? Why naming addon as 'office' instead of 'collabora'? |
wejdross
force-pushed
the
id-addon-billing
branch
from
3b810e6 to
5751cf3
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Context
Billing
We currently have a problem with billing as we are sending the same
instance_idfor service and it's add-on office(collabora). I order to fix this issue we decided to have a dedicated place for AddOns where we can easily track what addOns are available. This object will reside underspec.parameters. Once we know where the add ons objects are, we can easily track and use them across our comp-functions, including the billing. We also change the naming from collabora to office, as this is how it's defined in Odoo and it's also simpler to understand the add from the end user perspective.Checklist
bug,enhancement,documentation,change,breaking,dependencyas they show up in the changelog