Make sure backup retention is properly defaulted #284
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Due to a limitation in the kubebuilder framework, we need a hack to ensure that objects actually get the specified defaults.
3 tasks
Kidswiss
force-pushed
the
fix/default_backup_retetion
branch
from
dab7f61 to
4b59c17
Compare
Kidswiss
requested review from
a team,
TheBigLee,
wejdross and
zugao
and removed request for
a team
wejdross
approved these changes
Dec 12, 2024
I'm adding e2e tests for all services for that. However, I might not be able to finish it before my vacation. |
|
I;m taking Your ops tomorrow, so please just assign PR to me and leave comment explaining where to pick it up and I'll finish it |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Due to a limitation in the kubebuilder framework, we need a hack to ensure that objects actually get the specified defaults.
Checklist
bug,enhancement,documentation,change,breaking,dependencyas they show up in the changelog