Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make Crossplane 1.14 compatible #262

Merged
merged 2 commits into from
Nov 27, 2023
Merged

Make Crossplane 1.14 compatible #262

merged 2 commits into from
Nov 27, 2023

Conversation

Kidswiss
Copy link
Contributor

@Kidswiss Kidswiss commented Nov 21, 2023

For compositions where we use functions, they had to be re-structured, as in such cases the P+T part is just treated as another function.

For all non-function compositions no changes are necessary.

Checklist

  • The PR has a meaningful title. It will be used to auto generate the
    changelog.
    The PR has a meaningful description that sums up the change. It will be
    linked in the changelog.
  • PR contains a single logical change (to build a better changelog).
  • Categorize the PR by adding one of the labels:
    bug, enhancement, documentation, change, breaking, dependency
    as they show up in the changelog.
  • Link this PR to related issues or PRs.

@Kidswiss Kidswiss added the enhancement New feature or request label Nov 21, 2023
@Kidswiss Kidswiss force-pushed the change/xplane_114 branch 3 times, most recently from ae4e0c5 to c397ef1 Compare November 27, 2023 09:16
For compositions where we use functions, they had to be re-structured,
as in such cases the P+T part is just treated as another function.

For all non-function compositions no changes are necessary.
@Kidswiss Kidswiss requested review from a team, TheBigLee, wejdross and zugao and removed request for a team November 27, 2023 09:19
Copy link
Contributor

@zugao zugao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM but I have not tested it.

@TheBigLee TheBigLee self-requested a review November 27, 2023 10:43
@Kidswiss Kidswiss merged commit 4e3ed1d into master Nov 27, 2023
22 checks passed
@Kidswiss Kidswiss deleted the change/xplane_114 branch November 27, 2023 11:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants