Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't deploy billing prometheus rule for tests #553

Merged
merged 3 commits into from
Nov 27, 2024

Conversation

vshnbot
Copy link
Collaborator

@vshnbot vshnbot commented Nov 26, 2024

Summary

This will not deploy any billing data for instances where the claim resides in the vshn-test namespace.

Checklist

  • Categorize the PR by setting a good title and adding one of the labels:
    bug, enhancement, documentation, change, breaking, dependency
    as they show up in the changelog
  • Update tests.
  • Link this PR to related issues.

Link: vshn/appcat#272

@Kidswiss Kidswiss force-pushed the appcat/272/add/ignore-vshn-test-billing branch from 0a74d0a to 011fbee Compare November 26, 2024 13:45
@Kidswiss Kidswiss added the minor label Nov 26, 2024
@Kidswiss Kidswiss changed the title PR for appcat on add/ignore-vshn-test-billing Don't deploy billing prometheus rule for tests Nov 26, 2024
@Kidswiss Kidswiss requested review from a team, Kidswiss, TheBigLee and wejdross and removed request for a team November 26, 2024 14:07
@Kidswiss Kidswiss force-pushed the appcat/272/add/ignore-vshn-test-billing branch from 011fbee to b4fed8f Compare November 26, 2024 14:16
@Kidswiss Kidswiss force-pushed the appcat/272/add/ignore-vshn-test-billing branch from 2ef16c0 to c093c46 Compare November 26, 2024 15:00
@Kidswiss Kidswiss requested a review from zugao November 27, 2024 07:47
@Kidswiss Kidswiss merged commit 8624c83 into master Nov 27, 2024
10 checks passed
@Kidswiss Kidswiss deleted the appcat/272/add/ignore-vshn-test-billing branch November 27, 2024 09:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants