Fixes a bug with sorting names

vtbag · Sep 19, 2024 · dac7964 · dac7964
1 parent 6130dff
commit dac7964
Show file tree

Hide file tree

Showing 3 changed files with 9 additions and 4 deletions.
diff --git a/.changeset/gold-planets-provide.md b/.changeset/gold-planets-provide.md
@@ -0,0 +1,5 @@
+---
+'@vtbag/inspection-chamber': patch
+---
+
+Fixes a bug with name sorting
diff --git a/src/animations.ts b/src/animations.ts
@@ -99,7 +99,7 @@ export async function retrieveViewTransitionAnimations() {
 
 	initTwin(frameDoc, frameDoc, names, oldNames, newNames);
 
-	updateNames(names, oldNames, newNames);
+	updateNames(oldNames, newNames, names);
 }
 
 export function unleashAllAnimations() {

diff --git a/src/panel/names.ts b/src/panel/names.ts
@@ -11,9 +11,9 @@ import { mayViewTransition, vtActive } from './transition';
 export const THROTTLING_DELAY = 500;
 
 export function updateNames(
-	names: Set<string>,
 	leftTransitionNames: Set<string>,
-	rightTransitionNames?: Set<string>
+	rightTransitionNames?: Set<string>,
+	names?: Set<string>
 ) {
 	//navigator.clipboard.writeText("");
 	mayViewTransition(() => {
@@ -26,7 +26,7 @@ export function updateNames(
 		top!.document.querySelector<HTMLElement>('#vtbag-ui-names div')!.style.display =
 			rightTransitionNames ? 'flex' : 'none';
 		const list = top!.document.querySelector('#vtbag-ui-names > ol')!;
-		(rightTransitionNames ? names : [...names].sort()).forEach((name, idx) => {
+		(rightTransitionNames ? names! : [...leftTransitionNames].sort()).forEach((name, idx) => {
 			const li = top!.document.createElement('li');
 			li.innerText = name;
 			if (rightTransitionNames && leftTransitionNames.has(name)) {