Merge pull request #42 from vtex-apps/SO-4-update-all-used-versions-o…

…f-vtex-product-comparison-to-stop-using-apps-graphql-2-x chore: uses `publicSettingsForApp` endpoint to retrieve app settings
vtex-apps · Feb 24, 2023 · 3767de6 · 3767de6
2 parents 3053fde + 2e5797e
commit 3767de6
Show file tree

Hide file tree

Showing 4 changed files with 8 additions and 3 deletions.
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -7,6 +7,10 @@ and this project adheres to [Semantic Versioning](http://semver.org/spec/v2.0.0.
 
 ## [Unreleased]
 
+### Changed
+
+- Uses `publicSettingsForApp` endpoint to retrieve app settings
+
 ## [0.17.0] - 2022-06-15
 
 ### Added

diff --git a/manifest.json b/manifest.json
@@ -29,10 +29,11 @@
  "vtex.product-list-context": "0.x",
  "vtex.flex-layout": "0.x",
  "vtex.pixel-manager": "1.x",
- "vtex.apps-graphql": "2.x",
+ "vtex.apps-graphql": "3.x",
  "vtex.product-context": "0.x"
  },
  "settingsSchema": {
+ "access": "public",
  "title": "Product comparison",
  "type": "object",
  "properties": {

diff --git a/react/ProductComparisonContext.tsx b/react/ProductComparisonContext.tsx
@@ -212,7 +212,7 @@ const ProductComparisonProvider = ({ children }: Props) => {
 
  useEffect(() => {
  const appSettings = JSON.parse(
- pathOr(`{}`, ['appSettings', 'message'], appSettingsData)
+ pathOr(`{}`, ['publicSettingsForApp', 'message'], appSettingsData)
  )
 
  dispatch({

diff --git a/react/queries/AppSettings.graphql b/react/queries/AppSettings.graphql
@@ -1,5 +1,5 @@
 query AppSettings($version: String) {
- appSettings(app: "vtex.product-comparison", version: $version)
+ publicSettingsForApp(app: "vtex.product-comparison", version: $version)
  @context(provider: "vtex.apps-graphql") {
  message
  }