refac: check label before passing to the component

vtex-apps · Dec 20, 2023 · 6a79bd6 · 6a79bd6
1 parent 8e06157
commit 6a79bd6
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 12 deletions.
diff --git a/react/ProductSummaryCustom.tsx b/react/ProductSummaryCustom.tsx
@@ -184,10 +184,9 @@ function ProductSummaryCustom({
           >
             <Link className={linkClasses} {...linkProps}>
               <article className={summaryClasses}>
-                <SponsoredBadge
-                  label={sponsoredBadge?.label}
-                  showLabel={showSponsoredBadge}
-                />
+                {showSponsoredBadge ? (
+                  <SponsoredBadge label={sponsoredBadge?.label} />
+                ) : null}
                 {children}
               </article>
             </Link>

diff --git a/react/components/SponsoredBadge.tsx b/react/components/SponsoredBadge.tsx
@@ -10,21 +10,13 @@ type Props = {
    * The message ID or string for the sponsored label.
    */
   label?: string
-
-  /**
-   * Whether to show the sponsored label text.
-   */
-  showLabel?: boolean
 }
 
 export const SponsoredBadge = ({
   label = 'store/sponsoredBadge.title',
-  showLabel = false,
 }: Props) => {
   const { handles } = useCssHandles(CSS_HANDLES)
 
-  if (!showLabel) return null
-
   const containerClasses = classNames(
     handles.sponsoredBadgeContainer,
     'absolute z-1'