Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature: add sponsored tag if applicable #385

Merged
merged 8 commits into from
Nov 28, 2023
Merged

Conversation

hcaula
Copy link
Contributor

@hcaula hcaula commented Nov 16, 2023

What problem is this solving?

These changes renders a sponsored tag above the product's name if the product is sponsored.

How to test it?

Workspace

Screenshots or example usage:

Screenshot 2023-11-16 at 13 31 39

Related to / Depends on

Depends on:

@hcaula hcaula self-assigned this Nov 16, 2023
@hcaula hcaula requested review from a team as code owners November 16, 2023 16:45
@hcaula hcaula requested review from Isabella-Veloso and removed request for a team November 16, 2023 16:45
Copy link
Contributor

vtex-io-ci-cd bot commented Nov 16, 2023

Hi! I'm VTEX IO CI/CD Bot and I'll be helping you to publish your app! 🤖

Please select which version do you want to release:

  • Patch (backwards-compatible bug fixes)

  • Minor (backwards-compatible functionality)

  • Major (incompatible API changes)

And then you just need to merge your PR when you are ready! There is no need to create a release commit/tag.

  • No thanks, I would rather do it manually 😞

@hcaula hcaula requested review from gvc, RodrigoTadeuF and ArthurTriis1 and removed request for a team November 16, 2023 16:45
@vtex-io-docs-bot
Copy link

Beep boop 🤖

Thank you so much for keeping our documentation up-to-date ❤️

@@ -38,7 +38,7 @@
"vtex.render-runtime": "http://vtex.vtexassets.com/_v/public/typings/v1/vtex.render-runtime@8.132.4/public/@types/vtex.render-runtime",
"vtex.responsive-values": "http://vtex.vtexassets.com/_v/public/typings/v1/vtex.responsive-values@0.4.2/public/@types/vtex.responsive-values",
"vtex.search-page-context": "http://vtex.vtexassets.com/_v/public/typings/v1/vtex.search-page-context@0.2.0/public/@types/vtex.search-page-context",
"vtex.store-components": "http://vtex.vtexassets.com/_v/public/typings/v1/vtex.store-components@3.167.0/public/@types/vtex.store-components",
"vtex.store-components": "http://vtex.vtexassets.com/_v/public/typings/v1/vtex.store-components@3.170.0-beta.0/public/@types/vtex.store-components",
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This will be updated to the proper version once this PR is deployed.

filipewl pushed a commit to vtex-apps/store-components that referenced this pull request Nov 28, 2023
#### What problem is this solving?

📢  **We do not intend to ship this until after black friday!**  📢 

⚠️ The failed CI tests are not related to this change ⚠️ 

Our current solution for sponsored products exports a `sponsored-badge`
block in the [Sponsored
Products](https://github.com/vtex-apps/sponsored-products) app. However,
this requires changes in the `store-theme` in order to render sponsored
products.

By having this option here, the Product Summary app can render this
badge dynamically and automatically, without having to change the
store-theme.

#### How to test it?

<!--- Don't forget to add a link to a Workspace where this branch is
linked -->


[Workspace](https://caula--sjdigital.myvtex.com/cotonete?_q=cotonete&map=ft)

#### Screenshots or example usage:

<!--- Add some images or gifs to showcase changes in behaviour or
layout. Example: before and after images -->
![Screenshot 2023-11-16 at 13 31
39](https://github.com/vtex-apps/store-components/assets/15937541/ac7a72d3-7da5-413f-9156-1b231990f360)

#### Describe alternatives you've considered, if any.

<!--- Optional -->

#### Related to / Depends on

<!--- Optional -->
Related to vtex-apps/product-summary#385.
@filipewl filipewl merged commit bb563ce into master Nov 28, 2023
6 of 7 checks passed
@filipewl filipewl deleted the feature/sponsored-badge branch November 28, 2023 18:10
Copy link
Contributor

vtex-io-ci-cd bot commented Nov 28, 2023

Your PR has been merged! App is being published. 🚀
Version 2.86.0 → 2.87.0

After the publishing process has been completed (check #vtex-io-releases) and doing A/B tests with the new version, you can deploy your release by running:

vtex deploy vtex.product-summary@2.87.0

After that your app will be updated on all accounts.

For more information on the deployment process check the docs. 📖

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants