-
Notifications
You must be signed in to change notification settings - Fork 51
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature: add sponsored tag if applicable #385
Conversation
Hi! I'm VTEX IO CI/CD Bot and I'll be helping you to publish your app! 🤖 Please select which version do you want to release:
And then you just need to merge your PR when you are ready! There is no need to create a release commit/tag.
|
Beep boop 🤖 Thank you so much for keeping our documentation up-to-date ❤️ |
react/package.json
Outdated
@@ -38,7 +38,7 @@ | |||
"vtex.render-runtime": "http://vtex.vtexassets.com/_v/public/typings/v1/vtex.render-runtime@8.132.4/public/@types/vtex.render-runtime", | |||
"vtex.responsive-values": "http://vtex.vtexassets.com/_v/public/typings/v1/vtex.responsive-values@0.4.2/public/@types/vtex.responsive-values", | |||
"vtex.search-page-context": "http://vtex.vtexassets.com/_v/public/typings/v1/vtex.search-page-context@0.2.0/public/@types/vtex.search-page-context", | |||
"vtex.store-components": "http://vtex.vtexassets.com/_v/public/typings/v1/vtex.store-components@3.167.0/public/@types/vtex.store-components", | |||
"vtex.store-components": "http://vtex.vtexassets.com/_v/public/typings/v1/vtex.store-components@3.170.0-beta.0/public/@types/vtex.store-components", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This will be updated to the proper version once this PR is deployed.
#### What problem is this solving? 📢 **We do not intend to ship this until after black friday!** 📢⚠️ The failed CI tests are not related to this change⚠️ Our current solution for sponsored products exports a `sponsored-badge` block in the [Sponsored Products](https://github.com/vtex-apps/sponsored-products) app. However, this requires changes in the `store-theme` in order to render sponsored products. By having this option here, the Product Summary app can render this badge dynamically and automatically, without having to change the store-theme. #### How to test it? <!--- Don't forget to add a link to a Workspace where this branch is linked --> [Workspace](https://caula--sjdigital.myvtex.com/cotonete?_q=cotonete&map=ft) #### Screenshots or example usage: <!--- Add some images or gifs to showcase changes in behaviour or layout. Example: before and after images --> ![Screenshot 2023-11-16 at 13 31 39](https://github.com/vtex-apps/store-components/assets/15937541/ac7a72d3-7da5-413f-9156-1b231990f360) #### Describe alternatives you've considered, if any. <!--- Optional --> #### Related to / Depends on <!--- Optional --> Related to vtex-apps/product-summary#385.
Your PR has been merged! App is being published. 🚀 After the publishing process has been completed (check #vtex-io-releases) and doing A/B tests with the new version, you can deploy your release by running:
After that your app will be updated on all accounts. For more information on the deployment process check the docs. 📖 |
What problem is this solving?
These changes renders a sponsored tag above the product's name if the product is sponsored.
How to test it?
Workspace
Screenshots or example usage:
Related to / Depends on
Depends on: