Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature: supports multiple sponsored badge positions #390

Merged
merged 10 commits into from
Dec 21, 2023

Conversation

hcaula
Copy link
Contributor

@hcaula hcaula commented Dec 15, 2023

What problem is this solving?

In some stores, the layout doesn't work so well with the sponsored tag begin on top of the product's name.

So, we're now adding the option containerTop, that puts the sponsored tag on top of the product container in an absolute position. The store can then manipulate the finer details in their CSS.

How to test it?

Workspace

Screenshots or example usage:

Screenshot 2023-12-15 at 16 33 20 image

Related to / Depends on

Depends on: vtex-apps/product-summary-context#27

@hcaula hcaula self-assigned this Dec 15, 2023
@hcaula hcaula requested review from a team as code owners December 15, 2023 19:45
@hcaula hcaula requested review from sheilagomes, icazevedo, eduardoformiga and lucasfp13 and removed request for a team December 15, 2023 19:45
Copy link
Contributor

vtex-io-ci-cd bot commented Dec 15, 2023

Hi! I'm VTEX IO CI/CD Bot and I'll be helping you to publish your app! 🤖

Please select which version do you want to release:

  • Patch (backwards-compatible bug fixes)

  • Minor (backwards-compatible functionality)

  • Major (incompatible API changes)

And then you just need to merge your PR when you are ready! There is no need to create a release commit/tag.

  • No thanks, I would rather do it manually 😞

@vtex-io-docs-bot
Copy link

Beep boop 🤖

Thank you so much for keeping our documentation up-to-date ❤️

react/utils/shouldShowSponsoredBadge.ts Outdated Show resolved Hide resolved
react/components/SponsoredBadge.tsx Outdated Show resolved Hide resolved
docs/ProductSummaryShelf.md Outdated Show resolved Hide resolved
@hcaula hcaula force-pushed the feat/sponsored-badge-position branch from 39c49e0 to 2c44ddd Compare December 19, 2023 17:25
@hcaula hcaula requested a review from a team as a code owner December 19, 2023 17:25
Copy link

@chrsmutti chrsmutti left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@hcaula hcaula merged commit a02d6d3 into master Dec 21, 2023
5 of 6 checks passed
@hcaula hcaula deleted the feat/sponsored-badge-position branch December 21, 2023 12:24
Copy link
Contributor

vtex-io-ci-cd bot commented Dec 21, 2023

Your PR has been merged! App is being published. 🚀
Version 2.87.1 → 2.88.0

After the publishing process has been completed (check #vtex-io-releases) and doing A/B tests with the new version, you can deploy your release by running:

vtex deploy vtex.product-summary@2.88.0

After that your app will be updated on all accounts.

For more information on the deployment process check the docs. 📖

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants