Merge pull request #39 from vtex-apps/feature/bookmark

Add Bookmark

CHANGELOG.md

@@ -6,6 +6,8 @@ The format is based on [Keep a Changelog](http://keepachangelog.com/en/1.0.0/)
 and this project adheres to [Semantic Versioning](http://semver.org/spec/v2.0.0.html).
 
 ## [Unreleased]
+### Added
+- Icon Bookmark.
 
 ## [0.14.0] - 2019-11-22
 ### Added

ICONPACK.md → docs/ICONPACK.md

@@ -77,6 +77,8 @@ We use a series of prefixes to help us understand what an specific icon means.
 | ![](docs/mpa-clone--outline.svg)  | mpa-clone--outline | 
 | ![](docs/mpa-clone--filled.svg)  | mpa-clone--filled | 
 | ![](docs/mpa-edit--outline.svg)  | mpa-edit--outline | 
+| ![](docs/mpa-bookmark--filled.svg)  | mpa-bookmark--filled | 
+| ![](docs/mpa-bookmark--outline.svg)  | mpa-bookmark--outline | 
 | ![](docs/mpa-edit--filled.svg)  | mpa-edit--filled | 
 | ![](docs/mpa-external-link--line.svg)  | mpa-external-link--line | 
 | ![](docs/mpa-external-link--outline.svg)  | mpa-external-link--outline | 

docs/README.md

@@ -43,7 +43,7 @@ All Store icons components.
 
 ## Concept
 
-This project is based on [SVG fragment identifiers](https://css-tricks.com/svg-fragment-identifiers-work/). All store icons are served by Render SDK, and with HTML tag `<use>` we can render a fragment from our icon pack. If you want to know the complete list of fragment SVG's, [see here](https://github.com/vtex-apps/store-icons/blob/master/ICONPACK.md)
+This project is based on [SVG fragment identifiers](https://css-tricks.com/svg-fragment-identifiers-work/). All store icons are served by Render SDK, and with HTML tag `<use>` we can render a fragment from our icon pack. If you want to know the complete list of fragment SVG's, [see here](https://github.com/vtex-apps/store-icons/blob/master/docs/ICONPACK.md)
 
 ## Usage
 
@@ -145,6 +145,7 @@ Some components support modifiers. These are props that define the icon type, or
 | [IconSwap](https://github.com/vtex-apps/store-icons/blob/feature/docs/react/IconSwap.js)             | `swap`        | 🚫                        | 🚫          | 🚫        | 🚫    |
 | [IconHeart](https://github.com/vtex-apps/store-icons/blob/feature/docs/react/IconHeart.js)           | `heart`       | 🚫                        | 🚫          | 🚫        | 🚫    |
 | [IconGlobe](https://github.com/vtex-apps/store-icons/blob/feature/docs/react/IconGlobe.js)           | `globe`       | 🚫                        | 🚫          | 🚫        | 🚫    |
+| [IconBookmark](https://github.com/vtex-apps/store-icons/blob/feature/docs/react/IconBookmark.js)     | `bookmark`    | filled \| outline         | 🚫          | 🚫        | 🚫    |
 
 #### Navigation
 
@@ -165,7 +166,7 @@ In the [usage](#usage) section, we discuss two ways of using icons. These ways e
 
 ### Overwriting the default IconPack
 
-As mentioned before, all icon IDs are stored at the [iconpack.svg](https://github.com/vtex-apps/store-icons/blob/master/ICONPACK.md) file. You can overwrite the default one by:
+As mentioned before, all icon IDs are stored at the [iconpack.svg](https://github.com/vtex-apps/store-icons/blob/master/docs/ICONPACK.md) file. You can overwrite the default one by:
 
 1. On your [`store-theme`](https://github.com/vtex-apps/store-theme/tree/master/styles) create a new folder called `iconpacks`
 

docs/script/scrap-svg.js

@@ -23,7 +23,7 @@ $('g').toArray().map(element => {
 })
 
 const BASELINE_PATH = path.join(__dirname, 'baseline.md')
-const ICONPACK_PATH = path.join(__dirname, '..', '..', 'ICONPACK.md')
+const ICONPACK_PATH = path.join(__dirname, '..', 'ICONPACK.md')
 
 fs.copyFile(BASELINE_PATH, ICONPACK_PATH, (err) => {
   if (err) throw err

react/IconBookmark.tsx

@@ -0,0 +1,11 @@
+import React from 'react'
+
+import Icon from './components/Icon'
+import { getType } from './utils/helpers'
+
+const IconBoomark = ({ type = 'outline', ...props }: EnhancedIconProps) => {
+  const typeModifier = getType(type, 'filled, outline')
+  return <Icon id={`mpa-bookmark${typeModifier}`} {...props} />
+}
+
+export default IconBoomark

react/package.json

@@ -30,7 +30,7 @@
     "tslint": "^5.11.0",
     "tslint-config-vtex": "^2.0.0",
     "tslint-eslint-rules": "^5.4.0",
-    "typescript": "3.5.2"
+    "typescript": "3.7.3"
   },
   "resolutions": {
     "babel-core": "^7.0.0-bridge.0"

react/yarn.lock

@@ -4919,10 +4919,10 @@ type-check@~0.3.2:
   dependencies:
     prelude-ls "~1.1.2"
 
-typescript@3.5.2:
-  version "3.5.2"
-  resolved "https://registry.yarnpkg.com/typescript/-/typescript-3.5.2.tgz#a09e1dc69bc9551cadf17dba10ee42cf55e5d56c"
-  integrity sha512-7KxJovlYhTX5RaRbUdkAXN1KUZ8PwWlTzQdHV6xNqvuFOs7+WBo10TQUqT19Q/Jz2hk5v9TQDIhyLhhJY4p5AA==
+typescript@3.7.3:
+  version "3.7.3"
+  resolved "https://registry.yarnpkg.com/typescript/-/typescript-3.7.3.tgz#b36840668a16458a7025b9eabfad11b66ab85c69"
+  integrity sha512-Mcr/Qk7hXqFBXMN7p7Lusj1ktCBydylfQM/FZCk5glCNQJrCUKPkMHdo9R0MTFWsC/4kPFvDS0fDPvukfCkFsw==
 
 typescript@^3.3.3333:
   version "3.5.3"

store/interfaces.json

@@ -82,5 +82,8 @@
   },
   "icon-swap": {
     "component": "IconSwap"
+  },
+  "icon-bookmark": {
+    "component": "IconBookmark"
   }
 }