Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AddAffiliates query authentication fix #152

Merged
merged 1 commit into from
Oct 30, 2023

Conversation

GabrielBarross
Copy link
Contributor

What is the purpose of this pull request?

Our clients were having problems with the addAffiliates query on the storefront because of the new authentication that was based on the adminAuthToken, since everyone should have the possibility to create a new affiliate, I'm deleting the directive from this query

What problem is this solving?

  • Affiliates can now be added again on the storefront

How to test it?

Screenshots or example usage

Gravacao.de.Tela.2023-10-25.as.13.52.10.mov
Gravacao.de.Tela.2023-10-25.as.13.54.12.mov

How does this PR make you feel? 🔗

Types of changes

  • Chore (non-breaking change which doesn't change any functionalities)
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Requires change to documentation, which has been updated accordingly.

@GabrielBarross GabrielBarross self-assigned this Oct 25, 2023
@GabrielBarross GabrielBarross requested a review from a team as a code owner October 25, 2023 17:08
@GabrielBarross GabrielBarross requested review from ConradoClark and removed request for a team October 25, 2023 17:08
@vtex-io-ci-cd
Copy link

vtex-io-ci-cd bot commented Oct 25, 2023

Hi! I'm VTEX IO CI/CD Bot and I'll be helping you to publish your app! 🤖

Please select which version do you want to release:

  • Patch (backwards-compatible bug fixes)

  • Minor (backwards-compatible functionality)

  • Major (incompatible API changes)

And then you just need to merge your PR when you are ready! There is no need to create a release commit/tag.

  • No thanks, I would rather do it manually 😞

@github-actions
Copy link

Fails
🚫

We follow keepachangelog standards.

Please, change the file CHANGELOG.md adding a small summary of your changes under the [Unreleased] section. Example:

 ## [Unreleased]

+ ### Fixed
+ - Issue with image sizing in the SKU Selector.

Possible types of changes:

  • Added for new features.
  • Changed for changes in existing functionality.
  • Deprecated for soon-to-be removed features.
  • Removed for now removed features.
  • Fixed for any bug fixes.
  • Security in case of vulnerabilities.

Generated by 🚫 dangerJS against 3cf1aa6

Copy link

@ConradoClark ConradoClark left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@GabrielBarross GabrielBarross merged commit 12d21cf into fix-extended-md-class Oct 30, 2023
9 of 10 checks passed
@GabrielBarross GabrielBarross deleted the fix-add-affiliates-auth branch October 30, 2023 19:02
@vtex-io-ci-cd
Copy link

vtex-io-ci-cd bot commented Oct 30, 2023

Your PR has been merged! App is being published. 🚀
Version 1.7.0 → 1.7.1

After the publishing process has been completed (check #vtex-io-releases) and doing A/B tests with the new version, you can deploy your release by running:

vtex deploy vtex.affiliates@1.7.1

After that your app will be updated on all accounts.

For more information on the deployment process check the docs. 📖

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants