fix: Don't render PDP with no price #2142
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Gmantiqueira
requested review from
icazevedo and
renatamottam
and removed request for
a team
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit ecefaad:
|
icazevedo
reviewed
Dec 4, 2023
Sorry! I was still deploying, updated the description! |
| @@ -214,9 +214,13 @@ export const getStaticProps: GetStaticProps< | |||
|
|
|||
| const { data, errors = [] } = searchResult | |||
|
|
|||
| const hasPrice = data?.product?.offers.offers.some( | |||
There was a problem hiding this comment.
I wonder if we should move this logic to the faststore/api, throwing an isNotFoundError from there.
|
@Gmantiqueira do we still need this PR? |
|
Hey people! Just a quick update - I'm closing this PR as it seems the problem was actually due to an indexing issue. 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What's the purpose of this pull request?
Related to #2085, we were rendering PDPs with no associated price. They doesn't show in PLPs, but we can access the URL.
How it works?
This PR fixes that triggering the 404 page when we have no price associated.
How to test it?
Check those products, they're without price:
https://sfj-da92366--starter.preview.vtex.app/awesome-granite-cheese/p
https://sfj-da92366--starter.preview.vtex.app/sleek-wooden-chair-16834618/p
Starters Deploy Preview
References