-
Notifications
You must be signed in to change notification settings - Fork 16
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add async set cache #559
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
GusGuerra
requested review from
arturpimentel,
iago1501,
GusGuerra,
eduardocesb,
filafb and
a team
June 3, 2024 20:27
GusGuerra
approved these changes
Jun 3, 2024
GusGuerra
approved these changes
Jun 4, 2024
GusGuerra
approved these changes
Jun 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is the purpose of this pull request?
Enhance the HTTP client's cache middleware by adding an asynchronous option (
asyncSet
) for setting cache entries, improving performance by preventing blocking of the main execution flow.What problem is this solving?
Addresses performance bottlenecks caused by synchronous cache writes, which can lead to delays with large responses or frequent requests. The
asyncSet
option allows asynchronous cache writes, reducing latency and improving responsiveness.How should this be manually tested?
Setup:
node-vtex-api
withyarn link
andyarn watch
.vtex/api
(e.g.render-server
) with theyarn link @vtex/api
.Configuration:
asyncSetCache
in the HTTP client's settings.Monitoring:
'jaeger-debug-id': 'async_set_cache'
to the request for a page.Screenshots or example usage
Types of changes