New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

EDU-12745 | Update Marketplace APIs - Suggestions #1307

Merged

anabaarbosa merged 19 commits into master from fix-spectral-errors-suggestions-api

Sep 26, 2024

Contributor

anabaarbosa commented Aug 22, 2024

Adjustment of examples/defaults and fixed errors like:

must-end-descriptions-with-period
no-empty-descriptions

Types of changes

New content (endpoints, descriptions or fields from scratch)
Improvement (make an endpoint's title or description even better)
Spelling and grammar accuracy (self-explanatory)

Changelog

Do not forget to update your changes to our Developer Portal's changelog. Did you create a release note?

Yes, I already created a release note about this change.
No, but I am going to.


          Update VTEX - Marketplace APIs - Suggestions.json

10dfece

Fixed errors like:
- must-end-descriptions-with-period
- no-empty-descriptions
And adjustment of examples/defaults

anabaarbosa added the documentation label

anabaarbosa self-assigned this


          Update generated files by portman

c1db463

github-actions bot commented Aug 22, 2024

Thanks for your contribution. The .json file will be checked now with Spectral.

anabaarbosa added 6 commits

August 22, 2024 18:07


          Update VTEX - Marketplace APIs - Suggestions.json

f917720

Fix errors 2


          Update VTEX - Marketplace APIs - Suggestions.json

9cd4a88


          Update VTEX - Marketplace APIs - Suggestions.json

d696368


          Permissions and summaries

98f3adf


          Update VTEX - Marketplace APIs - Suggestions.json

1e926e7


          Update VTEX - Marketplace APIs - Suggestions.json

b11a93b

anabaarbosa requested a review from a team

August 23, 2024 16:30

anabaarbosa marked this pull request as ready for review

August 23, 2024 16:30

Isabella-Veloso reviewed

View reviewed changes

VTEX - Marketplace APIs - Suggestions.json Show resolved Hide resolved

Isabella-Veloso reviewed

View reviewed changes

VTEX - Marketplace APIs - Suggestions.json Outdated Show resolved Hide resolved

Isabella-Veloso reviewed

View reviewed changes

VTEX - Marketplace APIs - Suggestions.json Show resolved Hide resolved

Isabella-Veloso reviewed

View reviewed changes

VTEX - Marketplace APIs - Suggestions.json Show resolved Hide resolved

Isabella-Veloso reviewed

View reviewed changes

VTEX - Marketplace APIs - Suggestions.json Outdated Show resolved Hide resolved

Isabella-Veloso reviewed

View reviewed changes

VTEX - Marketplace APIs - Suggestions.json Outdated Show resolved Hide resolved

Isabella-Veloso reviewed

View reviewed changes

VTEX - Marketplace APIs - Suggestions.json Outdated Show resolved Hide resolved

Isabella-Veloso reviewed

View reviewed changes

VTEX - Marketplace APIs - Suggestions.json Outdated Show resolved Hide resolved

Isabella-Veloso reviewed

View reviewed changes

VTEX - Marketplace APIs - Suggestions.json Outdated Show resolved Hide resolved

Isabella-Veloso reviewed

View reviewed changes

VTEX - Marketplace APIs - Suggestions.json Outdated Show resolved Hide resolved

Isabella-Veloso reviewed

View reviewed changes

VTEX - Marketplace APIs - Suggestions.json Outdated Show resolved Hide resolved

Isabella-Veloso reviewed

View reviewed changes

VTEX - Marketplace APIs - Suggestions.json Outdated Show resolved Hide resolved

Isabella-Veloso reviewed

View reviewed changes

VTEX - Marketplace APIs - Suggestions.json Outdated Show resolved Hide resolved

Isabella-Veloso reviewed

View reviewed changes

VTEX - Marketplace APIs - Suggestions.json Outdated Show resolved Hide resolved

Isabella-Veloso reviewed

View reviewed changes

VTEX - Marketplace APIs - Suggestions.json Outdated Show resolved Hide resolved

Isabella-Veloso reviewed

View reviewed changes

VTEX - Marketplace APIs - Suggestions.json Outdated Show resolved Hide resolved

Isabella-Veloso reviewed

View reviewed changes

VTEX - Marketplace APIs - Suggestions.json Outdated Show resolved Hide resolved

Isabella-Veloso reviewed

View reviewed changes

VTEX - Marketplace APIs - Suggestions.json Show resolved Hide resolved

Isabella-Veloso reviewed

View reviewed changes

VTEX - Marketplace APIs - Suggestions.json Outdated Show resolved Hide resolved

Isabella-Veloso reviewed

View reviewed changes

VTEX - Marketplace APIs - Suggestions.json Outdated Show resolved Hide resolved

Isabella-Veloso reviewed

View reviewed changes

VTEX - Marketplace APIs - Suggestions.json Outdated Show resolved Hide resolved

Isabella-Veloso reviewed

View reviewed changes

VTEX - Marketplace APIs - Suggestions.json Outdated Show resolved Hide resolved

Isabella-Veloso reviewed

View reviewed changes

VTEX - Marketplace APIs - Suggestions.json Outdated Show resolved Hide resolved

Isabella-Veloso reviewed

View reviewed changes

VTEX - Marketplace APIs - Suggestions.json Outdated Show resolved Hide resolved

Isabella-Veloso reviewed

View reviewed changes

VTEX - Marketplace APIs - Suggestions.json Show resolved Hide resolved

Isabella-Veloso reviewed

View reviewed changes

VTEX - Marketplace APIs - Suggestions.json Outdated Show resolved Hide resolved

Isabella-Veloso requested changes

View reviewed changes

Contributor

Isabella-Veloso left a comment

Request changes

anabaarbosa and others added 8 commits

September 25, 2024 20:34


          Update VTEX - Marketplace APIs - Suggestions.json

75c6fab

Fixed errors like:
- must-end-descriptions-with-period
- no-empty-descriptions
And adjustment of examples/defaults


          Update generated files by portman

ca4bd07


          Update VTEX - Marketplace APIs - Suggestions.json

abed442

Fix errors 2


          Update VTEX - Marketplace APIs - Suggestions.json

403e5b4


          Update VTEX - Marketplace APIs - Suggestions.json


          Permissions and summaries

432c6da


          Update VTEX - Marketplace APIs - Suggestions.json

bfab52a


          Update VTEX - Marketplace APIs - Suggestions.json

70f6c04

anabaarbosa force-pushed the fix-spectral-errors-suggestions-api branch from b11a93b to 70f6c04 Compare

September 25, 2024 23:34

anabaarbosa and others added 3 commits

September 25, 2024 20:39


          Merge branch 'fix-spectral-errors-suggestions-api' of https://github.…

d86ed7e

…com/vtex/openapi-schemas into fix-spectral-errors-suggestions-api


          Apply suggestions from code review

1f8f103

Co-authored-by: Isabella Veloso Sá <77300325+Isabella-Veloso@users.noreply.github.com>


          Update VTEX - Marketplace APIs - Suggestions.json

5ff0d51

anabaarbosa requested a review from Isabella-Veloso

September 26, 2024 00:33

Isabella-Veloso approved these changes

View reviewed changes

Contributor

Isabella-Veloso left a comment

LGTM

anabaarbosa merged commit b03348b into master

2 of 3 checks passed

anabaarbosa deleted the fix-spectral-errors-suggestions-api branch

September 26, 2024 13:06

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels