Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

EDU-11062 New endpoint #1348

Merged
merged 2 commits into from
Oct 22, 2024
Merged

EDU-11062 New endpoint #1348

merged 2 commits into from
Oct 22, 2024

Conversation

geisecosta
Copy link
Contributor

Types of changes

  • New content (endpoints, descriptions or fields from scratch)
  • Improvement (make an endpoint's title or description even better)
  • Spelling and grammar accuracy (self-explanatory)

Changelog

Do not forget to update your changes to our Developer Portal's changelog. Did you create a release note?

  • Yes, I already created a release note about this change.
  • No, but I am going to.

@geisecosta geisecosta requested a review from a team October 22, 2024 13:51
Copy link

Thanks for your contribution. The .json file will be checked now with Spectral.

Copy link
Contributor

@PedroAntunesCosta PedroAntunesCosta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Não tem body? Acho estranho um PUT sem body. Também não entendi como esse endpoint cria uma nova tabela. É só pra criar a entidade e depois será preenchida de outra forma?

Mesmo que não tenha body de fato, acho que faz sentido esclarecer isso na description do endpoint.

@geisecosta
Copy link
Contributor Author

Não tem body? Acho estranho um PUT sem body. Também não entendi como esse endpoint cria uma nova tabela. É só pra criar a entidade e depois será preenchida de outra forma?

Mesmo que não tenha body de fato, acho que faz sentido esclarecer isso na description do endpoint.

Isso mesmo, o endpoint não tem body, conforme descrito neste documento. Testei o endpoint e ele está funcionando conforme as instruções descritas no documento.

@PedroAntunesCosta PedroAntunesCosta self-requested a review October 22, 2024 15:21
@geisecosta geisecosta merged commit 01729e5 into master Oct 22, 2024
1 check passed
@geisecosta geisecosta deleted the EDU-11062-New-endpoint branch October 22, 2024 16:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants