Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Get seller list (Fix seller type param) #1355

Merged
merged 4 commits into from
Nov 6, 2024

Conversation

PedroAntunesCosta
Copy link
Contributor

Types of changes

  • New content (endpoints, descriptions or fields from scratch)
  • Improvement (make an endpoint's title or description even better)
  • Spelling and grammar accuracy (self-explanatory)
  • Fix

Copy link

github-actions bot commented Nov 6, 2024

Thanks for your contribution. The .json file will be checked now with Spectral.

@@ -12857,7 +12857,7 @@
{
"name": "sellerType",
"in": "query",
"description": "Seller type.",
"description": "Seller type. There are two possible values for this parameter:\n\r- `1`: Regular sellers\n\r- `2`: White label sellers",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
"description": "Seller type. There are two possible values for this parameter:\n\r- `1`: Regular sellers\n\r- `2`: White label sellers",
"description": "There are two possible values for this parameter:\n\r- `1`: Regular sellers\n\r- `2`: [White label sellers](https://help.vtex.com/en/tutorial/seller-white-label--5orlGHyDHGAYciQ64oEgKa)",

Copy link
Contributor

@anabaarbosa anabaarbosa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@PedroAntunesCosta PedroAntunesCosta merged commit 2ee8625 into master Nov 6, 2024
1 of 4 checks passed
@PedroAntunesCosta PedroAntunesCosta deleted the fix/catalog/list-seller-params branch November 6, 2024 14:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants