#trivial Add storybook to the master branch #1314
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thayannevls
requested review from
matheusps,
jonathasbsouza,
emersonlaurentino,
estacioneto and
a team
|
This pull request is being automatically deployed with Vercel (learn more). 🔍 Inspect: https://vercel.com/styleguide-core/styleguide/i31592dz6 |
matheusps
reviewed
Aug 27, 2020
|
@matheusps Already migrated to v6.x 😄 |
thayannevls
force-pushed
the
feat/add-storybook
branch
from
97e3606
to
a2f8e49
Compare
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit 4f9b71f:
|
|
Oh, I see. So, why knoobs and not controls ? |
matheusps
approved these changes
Aug 28, 2020
| └── button.stories.tsx | ||
| ``` | ||
|
|
||
| #### Conventions |
thayannevls
force-pushed
the
feat/add-storybook
branch
from
a2f8e49
to
e74bcd0
Compare
thayannevls
force-pushed
the
feat/add-storybook
branch
from
e74bcd0
to
e715e73
Compare
|
@matheusps Thanks for the reminder! I forgot about the knobs and actions 😄 could you check again? |
estacioneto
force-pushed
the
feat/add-storybook
branch
from
e715e73
to
c7606ce
Compare
estacioneto
force-pushed
the
feat/add-storybook
branch
from
c7606ce
to
4f9b71f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is the purpose of this pull request?
This is a previously work done to the branch
features, but since this branch has been discontinued I'm moving to themaster.What problem is this solving?
We need an environment with hot-loading and isolated components builds to help us develop our components.
How should this be manually tested?
yarn && yarn storybookVisit http://localhost:6006/
Screenshots or example usage
Types of changes