Skip to content

Commit

Permalink
Fix syntax and add bucket as secret
Browse files Browse the repository at this point in the history
  • Loading branch information
vudiep411 committed Nov 25, 2024
1 parent 254c4ca commit e670586
Show file tree
Hide file tree
Showing 2 changed files with 2 additions and 3 deletions.
4 changes: 2 additions & 2 deletions .github/workflows/build-release-packages.yml
Original file line number Diff line number Diff line change
Expand Up @@ -69,7 +69,7 @@ jobs:
ref: ${{ inputs.version || github.ref_name }}
build_matrix: ${{ needs.generate-build-matrix.outputs.x86_64-build-matrix }}
region: us-west-2
bucket_name: valkey-build
bucket_name: ${{ secrets.AWS_S3_BUCKET }}
secrets:
role_to_assume: ${{ secrets.AWS_ROLE_TO_ASSUME }}

Expand All @@ -83,6 +83,6 @@ jobs:
ref: ${{ inputs.version || github.ref_name }}
build_matrix: ${{ needs.generate-build-matrix.outputs.arm64-build-matrix }}
region: us-west-2
bucket_name: valkey-build
bucket_name: ${{ secrets.AWS_S3_BUCKET }}
secrets:
role_to_assume: ${{ secrets.AWS_ROLE_TO_ASSUME }}
1 change: 0 additions & 1 deletion .github/workflows/call-build-linux-x86-packages.yml
Original file line number Diff line number Diff line change
Expand Up @@ -69,6 +69,5 @@ jobs:
mkdir -p packages-files
cp -rfv $TAR_FILE_NAME.tar* packages-files/
- name: Sync to S3
run: aws s3 sync packages-files s3://${{ inputs.bucket_name }}/releases/

0 comments on commit e670586

Please sign in to comment.