Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix #34, #63, #72: ignored props before component connects #81

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

riovir
Copy link

@riovir riovir commented Jul 2, 2020

Added awareness to CustomElement props in the initialization code. In order to stay backward compatible opted for attributes taking precedence. In scenarios, where users already set conflicting attributes and props, the component's behavior will remain unchanged.

Intends to:

Note that I also added Jest and in-comment globals to ESLint setup to make it pass on tests.

@hpx7
Copy link

hpx7 commented Sep 12, 2020

This is an important fix -- @kazupon are you the right person to look at this?

@metacurb
Copy link

It would be wonderful if this could be looked at! I also greatly need this fix

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants