Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(VDataTable): Add option to hide an entire column #20048

Open
wants to merge 1 commit into
base: dev
Choose a base branch
from

Conversation

SystemKeeper
Copy link

Description

This PR adds the option to hide entire columns by specifying hidden: true.

Would allow to workaround issues like #17863 by adding { key: "data-table-group", hidden: true },

Markup:

<template>
  <v-app>
    <v-container>
      <v-data-table
        :headers="headers"
        :items="desserts"
        item-value="name"
      />
    </v-container>
  </v-app>
</template>

<script>
  export default {
    data () {
      return {
        headers: [
          { title: 'Dessert (100g serving)', key: 'name' },
          { title: 'Calories', key: 'calories', hidden: true },
          { title: 'Fat (g)', key: 'fat' },
          { title: 'Carbs (g)', key: 'carbs' },
          { title: 'Protein (g)', key: 'protein' },
          { title: 'Iron (%)', key: 'iron' },
        ],
        desserts: [
          {
            name: 'Frozen Yogurt',
            calories: 159,
            fat: 6.0,
            carbs: 24,
            protein: 4.0,
            iron: '1%',
            gluten: false,
          },
          {
            name: 'Ice cream sandwich',
            calories: 237,
            fat: 9.0,
            carbs: 37,
            protein: 4.3,
            iron: '1%',
            gluten: false,
          },
          {
            name: 'Eclair',
            calories: 262,
            fat: 16.0,
            carbs: 23,
            protein: 6.0,
            iron: '7%',
            gluten: true,
          },
          {
            name: 'Cupcake',
            calories: 305,
            fat: 3.7,
            carbs: 67,
            protein: 4.3,
            iron: '8%',
            gluten: true,
          },
          {
            name: 'Gingerbread',
            calories: 356,
            fat: 16.0,
            carbs: 49,
            protein: 3.9,
            iron: '16%',
            gluten: true,
          },
          {
            name: 'Jelly bean',
            calories: 375,
            fat: 0.0,
            carbs: 94,
            protein: 0.0,
            iron: '0%',
            gluten: false,
          },
          {
            name: 'Lollipop',
            calories: 392,
            fat: 0.2,
            carbs: 98,
            protein: 0,
            iron: '2%',
            gluten: false,
          },
          {
            name: 'Honeycomb',
            calories: 408,
            fat: 3.2,
            carbs: 87,
            protein: 6.5,
            iron: '45%',
            gluten: true,
          },
          {
            name: 'Donut',
            calories: 452,
            fat: 25.0,
            carbs: 51,
            protein: 4.9,
            iron: '22%',
            gluten: true,
          },
          {
            name: 'KitKat',
            calories: 518,
            fat: 26.0,
            carbs: 65,
            protein: 7,
            iron: '6%',
            gluten: true,
          },
        ],
      }
    },
  }
</script>

@@ -52,6 +52,9 @@
& .v-data-table-header__content
display: contents

&.v-data-table-column--hidden
display: none
Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am not totally sure if this needs to have !important here as the d-none utility has? But it worked fine in my tests.

@johnleider
Copy link
Member

Can you rebase this to dev since it's a feature? Thank you!

@SystemKeeper SystemKeeper force-pushed the feat/noid-datatable-hide-column branch from 92adbdc to 6074445 Compare July 26, 2024 14:07
@SystemKeeper SystemKeeper changed the base branch from master to dev July 26, 2024 14:07
@SystemKeeper SystemKeeper force-pushed the feat/noid-datatable-hide-column branch from 6074445 to 1bfecea Compare July 26, 2024 15:50
@MajesticPotatoe MajesticPotatoe added T: feature A new feature C: VDataTable VDatatable labels Aug 1, 2024
@SystemKeeper SystemKeeper force-pushed the feat/noid-datatable-hide-column branch from 1bfecea to dde8714 Compare August 15, 2024 15:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
C: VDataTable VDatatable T: feature A new feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants