Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deprecate Redis-Named Fields #495

Merged
merged 2 commits into from
Nov 22, 2024

Conversation

christhemorse
Copy link
Contributor

Description

This PR matches the recent Govultr updates to remove the Redis-named fields and properties, replacing them with generic versions to eventually support other caching engines.

Checklist:

  • Have you checked to ensure there aren't other open Pull Requests for the same update/change?
  • Have you linted your code locally prior to submission?
  • Have you successfully ran tests with your changes locally?

@christhemorse christhemorse self-assigned this Nov 22, 2024
Copy link

Unit Tests and Coverage

Show Output
	github.com/vultr/vultr-cli/v3		coverage: 0.0% of statements

Pusher: @christhemorse, Action: pull_request_target

Copy link
Member

@optik-aper optik-aper left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

@optik-aper optik-aper merged commit 1c5cd50 into vultr:master Nov 22, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants