Merge pull request #553 from vultr/issue-550

#550 fix missing request type in bare-metals, add test case to avoid future issues
vultr · Dec 3, 2021 · 3344cde · 3344cde
2 parents c703cd1 + 35d88a3
commit 3344cde
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 1 deletion.
diff --git a/src/api/bare-metal.js b/src/api/bare-metal.js
@@ -132,7 +132,7 @@ exports.deleteInstance = {
  */
 exports.getInstanceIpv4Addresses = {
   url: '/bare-metals/{baremetal-id}/ipv4',
-  requestType: '',
+  requestType: 'GET',
   apiKeyRequired: true,
   parameters: {
     'baremetal-id': {

diff --git a/test/util.js b/test/util.js
@@ -8,6 +8,7 @@ exports.createTestSuite = (specificationFile, mockParameters, mockResponse) => {
   const apiModule = specificationFile.replace(/-([a-z])/g, function (str) {
     return str[1].toUpperCase()
   })
+  const validRequestTypes = ['GET', 'POST', 'PATCH', 'PUT', 'DELETE']
 
   jest.mock('node-fetch', () => jest.fn())
 
@@ -25,6 +26,10 @@ exports.createTestSuite = (specificationFile, mockParameters, mockResponse) => {
           }
         }
 
+        it('has a valid request type', () => {
+          expect(validRequestTypes.includes(endpoint.requestType)).toEqual(true)
+        })
+
         if (endpoint.apiKeyRequired) {
           it('requires an API key', () => {
             const vultrInstance = vultr.initialize()