-
Notifications
You must be signed in to change notification settings - Fork 31
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Convert vultr-node to typescript (Fixes #393) #754
Conversation
Unit Tests and CoverageShow Output
-----------------------|---------|----------|---------|---------|-------------------
|
Unit Tests and CoverageShow Output
-----------------------|---------|----------|---------|---------|-------------------
|
Awesome, thanks! Ill take a look soon. |
How soon? |
We appreciate the PR, but we're going to keep this repo as node(js) and create a new typescript repo. If you want to contribute to that we can follow up with you when that's underway |
Thanks for the update @AFatalErrror. Do you know when this might be happening? I may just fork if there's no timeline |
Description
Converted the codebase to typescript. I've not moved the tests over, but they work.
A reviewer probably should:
firewall.ts
and make sure they're intendedtypes.ts
,index.ts
andutils.ts
as this is where the most changes actually areRelated Issues
#393
Checklist: