fix: refactor for simplified migration code

boa/deployments.py

@@ -115,9 +115,7 @@ def __init__(self, path=":memory:"):
         self.db.execute(_CREATE_CMD)
 
         # Migration for legacy DB without filename column
-        if not self._filename_is_in_db():
-            self.db.execute("ALTER TABLE deployments ADD COLUMN filename text;")
-            self.db.commit()
+        self._apply_filename_migration()
 
     def __del__(self):
         self.db.close()
@@ -133,12 +131,14 @@ def insert_deployment(self, deployment: Deployment):
         self.db.execute(insert_cmd, tuple(values.values()))
         self.db.commit()
 
-    def _filename_is_in_db(self) -> bool:
+    def _apply_filename_migration(self) -> None:
         cursor = self.db.execute("PRAGMA table_info(deployments);")
         columns = [col[1] for col in cursor.fetchall()]
-        if "filename" in columns:
-            return True
-        return False
+        is_in_db = "filename" in columns
+        if is_in_db:
+            return
+        self.db.execute("ALTER TABLE deployments ADD COLUMN filename text;")
+        self.db.commit()
 
     def _get_deployments_from_sql(self, sql_query: str, parameters=(), /):
         cur = self.db.execute(sql_query, parameters)

tests/integration/network/anvil/test_network_env.py

@@ -153,5 +153,8 @@ def test_deployments_db_migration(temp_legacy_db_path):
     columns = [col[1] for col in cursor.fetchall()]
     assert "filename" not in columns
 
+    # This next line is what does the migration (added the filename column)
     db = DeploymentsDB(temp_legacy_db_path)
-    assert db._filename_is_in_db() is True
+    cursor = db.db.execute("PRAGMA table_info(deployments);")
+    columns = [col[1] for col in cursor.fetchall()]
+    assert "filename" in columns