Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Validate timetravel #201

Draft
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

charles-cooper
Copy link
Member

What I did

How I did it

How to verify it

Description for the changelog

Cute Animal Picture

Put a link to a cute animal picture inside the parenthesis-->

@@ -329,5 +329,10 @@ def time_travel(
assert blocks is not None # mypy hint
seconds = blocks * block_delta

self.evm.patch.timestamp += seconds
self.evm.patch.block_number += blocks
if (new_blknum := self.evm.patch.block_number + blocks) < 0:
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we really need to abbreviate?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

no 🤓 but i think abbreviations are fine for variables with small scope! when i read code, i associate scope with size of the variable name, if the variable name is too long i start hunting for references to it outside of its actual scope.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants