Added Dockerfile to build docker images from the source #75
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added Dockerfile with .dockerignore to streamline use of enex2notion. User can now build an image with '$ docker build -t <image_name>:>tag> .' Data volume is declared at /data, which client can map to the host directory where the .enex files reside. Entrypoint already specifies the launch script, all left to do is to add CLI arguments.
Added section with commands to build a docker image from the source as well as run it.
Codecov Report
@@ Coverage Diff @@
## master #75 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 51 51
Lines 1519 1519
=========================================
Hits 1519 1519
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
|
@akmal2409, thank you very much for contribution! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added Dockerfile with .dockerignore to streamline use of enex2notion.
User can now build an image with '$ docker build -t <image_name>:>tag> .'
Data volume is declared at /data, which client can map to the host directory where the .enex files reside.
Entrypoint already specifies the launch script, all left to do is to add CLI arguments.
Example of how to run after the build:
$ docker run --rm -t enex2notion:latest --token <token> /data/my_notebooksAlong that I have also updated the documentation, in particular the section containing installation instructions.
That is my very first pull request in life, if it is not up to your standards please let me know!
Thank you for this tool, it preserved all the formatting when exporting.