Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a note to explain the meaning of taglevels and kill level. #97

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

helmo
Copy link
Contributor

@helmo helmo commented Nov 29, 2019

No description provided.

@thompol
Copy link

thompol commented Aug 30, 2020

Shouldn't the note be added to all lng files?

@helmo
Copy link
Contributor Author

helmo commented Aug 31, 2020

now added :)

@thompol
Copy link

thompol commented Aug 31, 2020

Perfect, hope this gets merged.

@Churro
Copy link
Contributor

Churro commented Aug 31, 2020

Thanks for the work. Overall, it's welcome and a nice addition. However, personally I see no point in adding English language strings to localized files. This will just raise a gap such that some translations are more / less complete than others. So before merging, I'd prefer to have newly added strings translated in a meaningful way.

@thompol
Copy link

thompol commented Aug 31, 2020

By adding those, translators know there is a string left to translate. If you don't add it, it will probably never be added to the other languages.

@Churro
Copy link
Contributor

Churro commented Aug 31, 2020

Well, sounds like the chicken-egg problem. Still, our current preference is to have a tidy codebase and proper translations beforehand since (at least empirically) most people using the plugins do not see themselves as potential "translators" but tend to get stressed as soon as languages are mixed. If you're able to contribute with translations, you are, of course, very welcome to append commits to this PR.

@helmo
Copy link
Contributor Author

helmo commented Nov 13, 2020

Then how do you get anything changed or added that is translatable? I could blindly copy the answer from google translate...
Or do you have a way to reach someone for each language?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants