describe query parameter passing for public keys #37
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1 task
TallTed
suggested changes
Aug 8, 2023
| corresponding to the blockchain ecosystem within which it is valid. No DID | ||
| Document should be returned for a DID URL that is not a valid [CAIP-10][] URI. | ||
|
|
||
| In some contexts, such as in web-based interfaces for Solana or Tezos wallets, a |
There was a problem hiding this comment.
Suggested change
| In some contexts, such as in web-based interfaces for Solana or Tezos wallets, a | |
| In some contexts, such as web-based interfaces for Solana or Tezos wallets, a |
| In some contexts, such as in web-based interfaces for Solana or Tezos wallets, a | ||
| public key is traditionally passed by wallets to counterparties as part of | ||
| authentication, without which signatures cannot be verified and submitted to | ||
| public ledgers. In other contexts, such as in web-based interfaces for Ethereum |
There was a problem hiding this comment.
Suggested change
| public ledgers. In other contexts, such as in web-based interfaces for Ethereum | |
| public ledgers. In other contexts, such as web-based interfaces for Ethereum |
| wallets, a public key is cryptographically [recoverable][EC Recovery for | ||
| secp256k1] from a signature over a known message, but unknowable without one. In | ||
| all of these cases, a DID URL containing only the public-key hash will not be | ||
| enough to recover the corresponding public key and thus generate a useful DID |
There was a problem hiding this comment.
Suggested change
| enough to recover the corresponding public key and thus generate a useful DID | |
| enough to recover the corresponding public key and use it to generate a useful DID |
Comment on lines
+176
to
+178
| document; instead, a query parameter `pk` (i.e. `?pk=`) can be appended to a DID | ||
| PKH URL such that a DID document can be generated for that DID PKH URL. For a | ||
| valid DID URL (i.e. one conforming to [CAIP-10]) without the additional |
There was a problem hiding this comment.
Suggested change
| document; instead, a query parameter `pk` (i.e. `?pk=`) can be appended to a DID | |
| PKH URL such that a DID document can be generated for that DID PKH URL. For a | |
| valid DID URL (i.e. one conforming to [CAIP-10]) without the additional | |
| document; instead, the query parameter `pk` can be appended to a DID | |
| PKH URL (i.e., `?pk=`), and a DID document can be generated for that DID PKH URL. For a | |
| valid DID URL (i.e., one conforming to [CAIP-10]) without the additional |
| document; instead, a query parameter `pk` (i.e. `?pk=`) can be appended to a DID | ||
| PKH URL such that a DID document can be generated for that DID PKH URL. For a | ||
| valid DID URL (i.e. one conforming to [CAIP-10]) without the additional | ||
| information needed to generate a DID Document, an "empty" DID document |
There was a problem hiding this comment.
Suggested change
| information needed to generate a DID Document, an "empty" DID document | |
| information needed to generate a DID document, an "empty" DID document |
| that Spruce's implementation also supports for backwards-compatibility with | ||
| credentials already issued look like this: | ||
| namespacing rather than referring directly to the CAIP naming convention. It | ||
| also defaulted to main-net for `did:pkh:eth` in the absence of an explicit |
There was a problem hiding this comment.
Suggested change
| also defaulted to main-net for `did:pkh:eth` in the absence of an explicit | |
| also defaulted to `main-net` for `did:pkh:eth` in the absence of an explicit |
| credentials already issued look like this: | ||
| namespacing rather than referring directly to the CAIP naming convention. It | ||
| also defaulted to main-net for `did:pkh:eth` in the absence of an explicit | ||
| chainID. As the scope has grown of this project, and with forward compatibility |
There was a problem hiding this comment.
Suggested change
| chainID. As the scope has grown of this project, and with forward compatibility | |
| `chainID`. As the scope of this project has grown, and with forward compatibility |
| namespacing rather than referring directly to the CAIP naming convention. It | ||
| also defaulted to main-net for `did:pkh:eth` in the absence of an explicit | ||
| chainID. As the scope has grown of this project, and with forward compatibility | ||
| in mind, both of these patterns have been removed, required explicitly naming |
There was a problem hiding this comment.
Suggested change
| in mind, both of these patterns have been removed, required explicitly naming | |
| in mind, both of these patterns have been removed, now requiring explicitly naming |
Comment on lines
+277
to
+278
| implementation also supports for backwards-compatibility with credentials | ||
| already issued look like this: |
There was a problem hiding this comment.
Suggested change
| implementation also supports for backwards-compatibility with credentials | |
| already issued look like this: | |
| implementation also supports for backwards-compatibility with previously | |
| issued credentials look like this: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As per the CASA meeting today, trying to update did-pkh to reflect the complexity of sub-methods requiring recovery or pk-passing to generate DID documents. @chunningham i can't assign you because it's a CCG repo but feel free to review as well.