Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Build and deploy with spec-prod #48

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Build and deploy with spec-prod #48

wants to merge 1 commit into from

Conversation

clehner
Copy link
Member

@clehner clehner commented Apr 11, 2022

From https://github.com/w3c/spec-prod/blob/main/docs/examples.md#deploy-to-github-pages

  • Build and test on pull-request
  • Deploy to gh-pages branch on push to main

Deploying the built version enables the spec to work better in browsers without JavaScript, since the ids will all be set, etc. It will also mean a faster experience even with JS, since there will be fewer requests and processing on page load.

Testing should help us catch HTML/Respec errors.

@clehner clehner marked this pull request as ready for review April 11, 2022 20:40
Copy link
Collaborator

@awoie awoie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants