Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change figure & figcaption accName computation #359

Open
wants to merge 23 commits into
base: gh-pages
Choose a base branch
from

Commits on Jan 20, 2022

  1. Change figure & figcaption accName computation

    resolves #325
    
    This PR revises the mappings for `figure` and `figcaption` to remove the "labelled by" relations, changing them to "details for".
    The accessible name computation for `figure` removes `figcaption`, a note is added to further reference this change.
    
    TODO: 
    - [ ] need to check on updates to UIA mapping, if any.
    - [ ] do we want `figcaption` to map to `caption`? 
    - [ ] regardless of above, [`caption`](https://w3c.github.io/aria/#caption) will need to be updated in regards to its referencing `figure` and `figcaption` relationships
    - [ ] [`aria-details`](https://w3c.github.io/aria/#aria-details) definition should be updated to reference this change
    scottaohara committed Jan 20, 2022
    Configuration menu
    Copy the full SHA
    941668e View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    c1f0436 View commit details
    Browse the repository at this point in the history

Commits on Feb 7, 2022

  1. Configuration menu
    Copy the full SHA
    472d40e View commit details
    Browse the repository at this point in the history
  2. resolve review comments

    scottaohara committed Feb 7, 2022
    Configuration menu
    Copy the full SHA
    0a0f361 View commit details
    Browse the repository at this point in the history

Commits on Apr 4, 2022

  1. Configuration menu
    Copy the full SHA
    8d36f54 View commit details
    Browse the repository at this point in the history

Commits on Apr 29, 2022

  1. Configuration menu
    Copy the full SHA
    8e3e598 View commit details
    Browse the repository at this point in the history
  2. add in AX details for figure's relationship to figcaption

    cc @cookiecrook to make sure i got this right.  thank you
    scottaohara committed Apr 29, 2022
    Configuration menu
    Copy the full SHA
    8841502 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    295f94b View commit details
    Browse the repository at this point in the history

Commits on Jun 6, 2022

  1. Configuration menu
    Copy the full SHA
    4bae8c9 View commit details
    Browse the repository at this point in the history

Commits on Jul 9, 2022

  1. Configuration menu
    Copy the full SHA
    eee657b View commit details
    Browse the repository at this point in the history

Commits on Oct 14, 2022

  1. Configuration menu
    Copy the full SHA
    4471139 View commit details
    Browse the repository at this point in the history

Commits on May 3, 2023

  1. finish up mapping detials

    verified the UIA mappings with help from @benbeaudry 
    made some of the wording consistent between mappings
    added in a SHOULD to indicate that if a figure is explicitly provided an accessible name from its figcaption, then do not expose the details relationship, as that'd add redundancy.
    scottaohara committed May 3, 2023
    Configuration menu
    Copy the full SHA
    a8a4c01 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    f22b76b View commit details
    Browse the repository at this point in the history
  3. attempt to fix build error

    saying it doesn't know what accname is... so, replacing the instances of the links which may be causing the issue?
    scottaohara committed May 3, 2023
    Configuration menu
    Copy the full SHA
    1108f16 View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    6fa6be7 View commit details
    Browse the repository at this point in the history
  5. Configuration menu
    Copy the full SHA
    db3e5b7 View commit details
    Browse the repository at this point in the history
  6. Configuration menu
    Copy the full SHA
    82af13a View commit details
    Browse the repository at this point in the history

Commits on Jun 4, 2023

  1. Configuration menu
    Copy the full SHA
    3fd830d View commit details
    Browse the repository at this point in the history
  2. add comment regarding aria-details

    see https://bugs.chromium.org/p/chromium/issues/detail?id=1426613#c4
    
    aria-details with an empty string could be useful to authors if there was a specific need to _not_ expose a child figcaption - e.g., if the elements need to have remapped roles for whatever reason.
    scottaohara committed Jun 4, 2023
    Configuration menu
    Copy the full SHA
    2339df0 View commit details
    Browse the repository at this point in the history

Commits on Oct 25, 2023

  1. Configuration menu
    Copy the full SHA
    7263462 View commit details
    Browse the repository at this point in the history

Commits on Nov 22, 2023

  1. Configuration menu
    Copy the full SHA
    7839c03 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    9a81370 View commit details
    Browse the repository at this point in the history

Commits on Dec 13, 2023

  1. Configuration menu
    Copy the full SHA
    2380d76 View commit details
    Browse the repository at this point in the history