normalize “an empty string” to “the empty string” #544
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
scottaohara
reviewed
Apr 18, 2024
scottaohara
reviewed
Apr 18, 2024
scottaohara
reviewed
Apr 18, 2024
Co-authored-by: Scott O'Hara <scottaohara@users.noreply.github.com>
Co-authored-by: Scott O'Hara <scottaohara@users.noreply.github.com>
scottaohara
reviewed
Apr 18, 2024
Co-authored-by: Scott O'Hara <scottaohara@users.noreply.github.com>
Co-authored-by: Scott O'Hara <scottaohara@users.noreply.github.com>
|
thanks for this (and immediately pulling in my nits for commas that are beyond your PR :) ) |
pkra
pushed a commit
to w3c/aria
that referenced
this pull request
Apr 18, 2024
Related to w3c/html-aam#514 This normalizes all instances of “_**an** empty string_” to “_**the** empty string_”. I’ve opened an equivalent HTML-AAM PR in w3c/html-aam#544. I checked accname and confirmed that it already uses “_the empty string_” consistently throughout.
scottaohara
approved these changes
Apr 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #514.
This normalizes all instances of “an empty string” to “the empty string”.
I’ve opened an equivalent ARIA PR for the ARIA spec in w3c/aria#2163.
I checked accname and confirmed that it already uses “the empty string” consistently throughout.
Preview | Diff