Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: dir's auto definition #1118

Merged
merged 11 commits into from
Jun 6, 2024
Merged

fix: dir's auto definition #1118

merged 11 commits into from
Jun 6, 2024

Conversation

marcoscaceres
Copy link
Member

@marcoscaceres marcoscaceres commented May 2, 2024

Closes #1079

This change (choose at least one, delete ones that don't apply):

  • Breaks existing normative behavior (please add label "breaking")
  • Adds new normative requirements
  • Adds new normative recommendations or optional items
  • Makes editorial changes (changes informative sections, or changes normative sections without changing behavior)
  • Is a "chore" (metadata, formatting, fixing warnings, etc).

Implementation commitment (delete if not making normative changes):

If change is normative, and it adds or changes a member:

Commit message:

(Fill in. If making normative changes, describe exactly what the behavioral
difference will be.)

Person merging, please make sure that commits are squashed with one of the following as a commit message prefix:

  • chore:
  • editorial:
  • BREAKING CHANGE:
  • And use none if it's a normative change

Preview | Diff

index.html Outdated Show resolved Hide resolved
index.html Outdated Show resolved Hide resolved
@mgiuca
Copy link
Collaborator

mgiuca commented May 3, 2024

I can review this when it's ready (are you still working on it)?

@marcoscaceres marcoscaceres requested a review from mgiuca May 3, 2024 07:38
@marcoscaceres
Copy link
Member Author

Thanks @mgiuca... then we should get @aphillips's eye's on it for approval.

Copy link
Contributor

@aphillips aphillips left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me! Thanks.

Copy link
Collaborator

@mgiuca mgiuca left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we can fix up some other text in this section while we're here.

  1. "implying that the value of the localizable members is by default:" -- I don't know how to parse this part of the sentence (it's right before the list of options). Delete it.

  2. "the use agent SHOULD" - s/use/user/

  3. Replace "When displaying the localizable members to an end-user..." with:

"The user agent SHOULD display the localizable members to the end-user using the [BIDI] algorithm. If the base direction is ltr or rtl, the user agent SHOULD override Rule P3 of [BIDI] ..."

(Remove the ordered list and drop list item 2 entirely - there is no need to explicitly state what happens in the "auto" case since it's covered by Bidi automatically. And we already have non-normative text to explain what happens in this case, above.)

(Also, it shouldn't say "apply Rule P1"; rule P2 is where the first strong character is chosen. But I would advise deleting this sentence entirely.)

index.html Outdated Show resolved Hide resolved
index.html Outdated Show resolved Hide resolved
index.html Outdated Show resolved Hide resolved
index.html Outdated Show resolved Hide resolved
index.html Outdated Show resolved Hide resolved
@marcoscaceres marcoscaceres requested a review from mgiuca June 6, 2024 23:12
@marcoscaceres
Copy link
Member Author

@mgiuca, revised based on your feedback. Taking @dmurph review as the basis for merging.

We can do any additional fixes as a follow up.

@marcoscaceres marcoscaceres merged commit 55e6818 into main Jun 6, 2024
2 checks passed
@marcoscaceres marcoscaceres deleted the auto_dir branch June 6, 2024 23:15
github-actions bot added a commit that referenced this pull request Jun 6, 2024
SHA: 55e6818
Reason: push, by marcoscaceres

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Value auto for dir probably shouldn't say "no explicit directionality"
4 participants