New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove problematic icon matching algorithm #1120

Merged

marcoscaceres merged 9 commits into main from icons

Jun 6, 2024

Member

marcoscaceres commented May 2, 2024 •

edited by pr-preview bot

Loading

Closes #1094

This change (choose at least one, delete ones that don't apply):

Breaks existing normative behavior (please add label "breaking")
Adds new normative requirements
Adds new normative recommendations or optional items
Makes editorial changes (changes informative sections, or changes normative sections without changing behavior)
Is a "chore" (metadata, formatting, fixing warnings, etc).

Implementation commitment (delete if not making normative changes):

If change is normative, and it adds or changes a member:

updated JSON schema

Commit message:

(Fill in. If making normative changes, describe exactly what the behavioral
difference will be.)

Person merging, please make sure that commits are squashed with one of the following as a commit message prefix:

chore:
editorial:
BREAKING CHANGE:
And use none if it's a normative change

marcoscaceres added 2 commits

May 3, 2024 09:19


Remove problematic icon matching algorithm

16c857a


fixup definition of any

f236422

marcoscaceres commented

View reviewed changes

index.html Outdated Show resolved Hide resolved


Update index.html

f7607cf

marcoscaceres commented

View reviewed changes

index.html Outdated Show resolved Hide resolved


Update index.html

8a08c87

marcoscaceres commented

View reviewed changes

index.html Outdated Show resolved Hide resolved


Update index.html

505ee87

dmurph reviewed

View reviewed changes

index.html Outdated Show resolved Hide resolved

marcoscaceres commented

View reviewed changes

index.html Outdated Show resolved Hide resolved

marcoscaceres and others added 2 commits

May 3, 2024 09:38


Update index.html

a31c1ce


tidy

174e475

marcoscaceres commented

View reviewed changes

index.html Outdated Show resolved Hide resolved


Update index.html

b6cce1c

dmurph reviewed

View reviewed changes

index.html Show resolved Hide resolved

Collaborator

mgiuca commented May 3, 2024

+1 to the general idea of this: it's overly restrictive and UAs should be able to choose the best icon of all the icons (assuming they follow the requirements of the "purpose" field).

dmurph approved these changes

View reviewed changes

index.html Show resolved Hide resolved


Merge branch 'main' into icons

b877a03

marcoscaceres merged commit 2f54efe into main

2 checks passed

marcoscaceres deleted the icons branch

June 6, 2024 23:01

github-actions bot added a commit that referenced this pull request


Remove problematic icon matching algorithm (#1120)

baafc9c

SHA: 2f54efe
Reason: push, by marcoscaceres

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment