Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Processing steps for id now removes the fragment #1122

Merged
merged 13 commits into from
Jun 6, 2024
Merged

Processing steps for id now removes the fragment #1122

merged 13 commits into from
Jun 6, 2024

Commits on May 6, 2024

  1. (unrelated) more formal language to set scope's query and fragment to… 

    … null.
    @mgiuca
    mgiuca committed May 6, 2024
    Configuration menu
    Copy the full SHA
    09ee6fd View commit details
    Browse the repository at this point in the history

  2. id processing: Set fragment to null in the processor. 

    Update and add examples.
    @mgiuca
    mgiuca committed May 6, 2024
    Configuration menu
    Copy the full SHA
    d96b247 View commit details
    Browse the repository at this point in the history

  3. Do not exclude fragments when comparing the manifest id with the docu… 

    …ment manifest id.

Since these are both processed in real time (not from a database) there is no need to exclude fragments here.
    @mgiuca
    mgiuca committed May 6, 2024
    Configuration menu
    Copy the full SHA
    2bbb99b View commit details
    Browse the repository at this point in the history

  4. Properly link to exclude fragments.

    @mgiuca
    mgiuca committed May 6, 2024
    Configuration menu
    Copy the full SHA
    6814169 View commit details
    Browse the repository at this point in the history

  5. Added note about why we still exclude fragments when comparing to the… 

    … app database.
    @mgiuca
    mgiuca committed May 6, 2024
    Configuration menu
    Copy the full SHA
    04a8f52 View commit details
    Browse the repository at this point in the history

  6. Rewrote the exclude fragments note, and made exclude fragments optional. 

    If it's just about old data, it should be up to the UA to know whether that old data might exist.
    @mgiuca
    mgiuca committed May 6, 2024
    Configuration menu
    Copy the full SHA
    70792c0 View commit details
    Browse the repository at this point in the history

Commits on May 10, 2024

  1. Fix id link 

    Co-authored-by: Marcos Cáceres <marcos@marcosc.com>
    @mgiuca @marcoscaceres
    mgiuca and marcoscaceres committed May 10, 2024
    Configuration menu
    Copy the full SHA
    2540edf View commit details
    Browse the repository at this point in the history

  2. Fix id link

    @mgiuca
    mgiuca committed May 10, 2024
    Configuration menu
    Copy the full SHA
    03f8c65 View commit details
    Browse the repository at this point in the history

Commits on May 22, 2024

  1. Tidy.

    @mgiuca
    mgiuca committed May 22, 2024
    Configuration menu
    Copy the full SHA
    11ff7cb View commit details
    Browse the repository at this point in the history

  2. Respond to review (non-normative phrasing).

    @mgiuca
    mgiuca committed May 22, 2024
    Configuration menu
    Copy the full SHA
    1282936 View commit details
    Browse the repository at this point in the history

  3. Rewrite OPTIONAL.

    @mgiuca
    mgiuca committed May 22, 2024
    Configuration menu
    Copy the full SHA
    9ac3a95 View commit details
    Browse the repository at this point in the history

Commits on Jun 6, 2024

  1. Merge branch 'main' into id-no-fragment

    @marcoscaceres
    marcoscaceres committed Jun 6, 2024
    Configuration menu
    Copy the full SHA
    ee7537c View commit details
    Browse the repository at this point in the history

  2. Apply suggestions from code review

    @marcoscaceres
    marcoscaceres committed Jun 6, 2024
    Configuration menu
    Copy the full SHA
    86c8d94 View commit details
    Browse the repository at this point in the history