Editorial: Update use of WebIDL "invoke a callback function" #270
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This algorithm can now handle the need to report an exception thrown by the callback. Some small tweaks are made for consistency with other specifications. Part of whatwg/webidl#1425.
|
@clelland have a chance to look? |
16 tasks
|
The extra LGTM, thanks! |
|
I don't have write access to this repository; is it possible for you to merge for me? (there does seem to be a build failure is unrelated to my change, though) |
|
Yeah, there is a build failure; I'm going to see if I can clean that up first and then commit this. |
github-actions bot
added a commit
that referenced
this pull request
Aug 13, 2024
SHA: 36c72cc Reason: push, by clelland Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
github-actions bot
added a commit
that referenced
this pull request
Aug 13, 2024
SHA: 36c72cc Reason: push, by clelland Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This algorithm can now handle the need to report an exception thrown by the callback. Some small tweaks are made for consistency with other specifications.
Part of whatwg/webidl#1425.