Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New Page About Balances & Locks #5859

Merged
merged 35 commits into from
May 7, 2024
Merged

New Page About Balances & Locks #5859

merged 35 commits into from
May 7, 2024

Conversation

filippoweb3
Copy link
Contributor

@filippoweb3 filippoweb3 commented May 2, 2024

  • New Page about Balances and Locks + figures
  • Add OpenGov Locks Figures to Gov Page, reorg
  • Broken links fix
  • Check major grammar errors

@filippoweb3 filippoweb3 changed the title New Page About Locks New Page About Balances & Locks May 6, 2024
@filippoweb3 filippoweb3 requested a review from DrW3RK May 6, 2024 14:36
@filippoweb3 filippoweb3 added A2 - Please Review Pull request is ready for review. and removed A1 - In Progress Not ready for review yet. labels May 6, 2024
Copy link
Member

@DrW3RK DrW3RK left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Rephrased content in some sections. May be it is worth adding a note at the beginning of the account balances example section saying that the examples are for the upcoming improvements to be deployed soon.

docs/learn/learn-account-balances.md Outdated Show resolved Hide resolved
docs/learn/learn-account-balances.md Outdated Show resolved Hide resolved
docs/learn/learn-account-balances.md Outdated Show resolved Hide resolved
docs/learn/learn-account-balances.md Outdated Show resolved Hide resolved
docs/learn/learn-account-balances.md Outdated Show resolved Hide resolved
docs/learn/learn-account-balances.md Outdated Show resolved Hide resolved
docs/learn/learn-accounts.md Outdated Show resolved Hide resolved
docs/learn/learn-accounts.md Outdated Show resolved Hide resolved
docs/learn/learn-polkadot-opengov.md Outdated Show resolved Hide resolved
docs/learn/learn-polkadot-opengov.md Outdated Show resolved Hide resolved
@DrW3RK
Copy link
Member

DrW3RK commented May 7, 2024

Good job with the figures. Very intuitive 👍

filippoweb3 and others added 13 commits May 7, 2024 18:27
Co-authored-by: Radha <86818441+DrW3RK@users.noreply.github.com>
Co-authored-by: Radha <86818441+DrW3RK@users.noreply.github.com>
Co-authored-by: Radha <86818441+DrW3RK@users.noreply.github.com>
Co-authored-by: Radha <86818441+DrW3RK@users.noreply.github.com>
Co-authored-by: Radha <86818441+DrW3RK@users.noreply.github.com>
Co-authored-by: Radha <86818441+DrW3RK@users.noreply.github.com>
Co-authored-by: Radha <86818441+DrW3RK@users.noreply.github.com>
Co-authored-by: Radha <86818441+DrW3RK@users.noreply.github.com>
Co-authored-by: Radha <86818441+DrW3RK@users.noreply.github.com>
Co-authored-by: Radha <86818441+DrW3RK@users.noreply.github.com>
Co-authored-by: Radha <86818441+DrW3RK@users.noreply.github.com>
Co-authored-by: Radha <86818441+DrW3RK@users.noreply.github.com>
Co-authored-by: Radha <86818441+DrW3RK@users.noreply.github.com>
filippoweb3 and others added 15 commits May 7, 2024 18:32
Co-authored-by: Radha <86818441+DrW3RK@users.noreply.github.com>
Co-authored-by: Radha <86818441+DrW3RK@users.noreply.github.com>
Co-authored-by: Radha <86818441+DrW3RK@users.noreply.github.com>
Co-authored-by: Radha <86818441+DrW3RK@users.noreply.github.com>
Co-authored-by: Radha <86818441+DrW3RK@users.noreply.github.com>
Co-authored-by: Radha <86818441+DrW3RK@users.noreply.github.com>
Co-authored-by: Radha <86818441+DrW3RK@users.noreply.github.com>
Co-authored-by: Radha <86818441+DrW3RK@users.noreply.github.com>
Co-authored-by: Radha <86818441+DrW3RK@users.noreply.github.com>
Co-authored-by: Radha <86818441+DrW3RK@users.noreply.github.com>
Co-authored-by: Radha <86818441+DrW3RK@users.noreply.github.com>
Co-authored-by: Radha <86818441+DrW3RK@users.noreply.github.com>
Co-authored-by: Radha <86818441+DrW3RK@users.noreply.github.com>
Co-authored-by: Radha <86818441+DrW3RK@users.noreply.github.com>
@filippoweb3 filippoweb3 merged commit defbcce into master May 7, 2024
2 checks passed
@filippoweb3 filippoweb3 deleted the locks branch May 7, 2024 16:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A2 - Please Review Pull request is ready for review.
Projects
None yet
2 participants