-
Notifications
You must be signed in to change notification settings - Fork 2.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
New Page About Balances & Locks #5859
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
filippoweb3
commented
May 2, 2024
•
edited
Loading
edited
- New Page about Balances and Locks + figures
- Add OpenGov Locks Figures to Gov Page, reorg
- Broken links fix
- Check major grammar errors
This was
linked to
issues
May 2, 2024
- new figures locks - reorg content - rm duplicates
filippoweb3
added
A2 - Please Review
Pull request is ready for review.
and removed
A1 - In Progress
Not ready for review yet.
labels
May 6, 2024
DrW3RK
approved these changes
May 7, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Rephrased content in some sections. May be it is worth adding a note at the beginning of the account balances example section saying that the examples are for the upcoming improvements to be deployed soon.
Good job with the figures. Very intuitive 👍 |
Co-authored-by: Radha <86818441+DrW3RK@users.noreply.github.com>
Co-authored-by: Radha <86818441+DrW3RK@users.noreply.github.com>
Co-authored-by: Radha <86818441+DrW3RK@users.noreply.github.com>
Co-authored-by: Radha <86818441+DrW3RK@users.noreply.github.com>
Co-authored-by: Radha <86818441+DrW3RK@users.noreply.github.com>
Co-authored-by: Radha <86818441+DrW3RK@users.noreply.github.com>
Co-authored-by: Radha <86818441+DrW3RK@users.noreply.github.com>
Co-authored-by: Radha <86818441+DrW3RK@users.noreply.github.com>
Co-authored-by: Radha <86818441+DrW3RK@users.noreply.github.com>
Co-authored-by: Radha <86818441+DrW3RK@users.noreply.github.com>
Co-authored-by: Radha <86818441+DrW3RK@users.noreply.github.com>
Co-authored-by: Radha <86818441+DrW3RK@users.noreply.github.com>
Co-authored-by: Radha <86818441+DrW3RK@users.noreply.github.com>
Co-authored-by: Radha <86818441+DrW3RK@users.noreply.github.com>
Co-authored-by: Radha <86818441+DrW3RK@users.noreply.github.com>
Co-authored-by: Radha <86818441+DrW3RK@users.noreply.github.com>
Co-authored-by: Radha <86818441+DrW3RK@users.noreply.github.com>
Co-authored-by: Radha <86818441+DrW3RK@users.noreply.github.com>
Co-authored-by: Radha <86818441+DrW3RK@users.noreply.github.com>
Co-authored-by: Radha <86818441+DrW3RK@users.noreply.github.com>
Co-authored-by: Radha <86818441+DrW3RK@users.noreply.github.com>
Co-authored-by: Radha <86818441+DrW3RK@users.noreply.github.com>
Co-authored-by: Radha <86818441+DrW3RK@users.noreply.github.com>
Co-authored-by: Radha <86818441+DrW3RK@users.noreply.github.com>
Co-authored-by: Radha <86818441+DrW3RK@users.noreply.github.com>
Co-authored-by: Radha <86818441+DrW3RK@users.noreply.github.com>
Co-authored-by: Radha <86818441+DrW3RK@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.