Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR updates
curve25519-dalek
to 4.1.0, which (among other things) will detect and use an appropriate SIMD backend at runtime, which should speed things up.One notable change is that the
Scalar::from_bits
is now deprecated as it requires the scalar to be reduced (and this is not verified) otherwise operations other than multiplications will be broken. We use this three times, and two of those uses are always valid (the scalars passed there are AFAIK always guaranteed to be reduced). For the third one inSecretKey::from_ed25519_bytes
I've just made it check that this is the case. (So now that function will return an error when passed an invalid key.)I've also removed the
precomputed-tables
feature flag because disabling it seems to be broken anyway: when it's disabled the crate doesn't compile anymore.