set minimum subtle version to 2.4.1 #99
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Interestingly, dalek itself only uses subtle 2.3, so yes let's merge this once CI runs. We only switched to 2.5 due to using -ng for a while, or due to blindly upgrading. I've no idea why subtle dislikes having multiple versions. I found no In principle of course, subtle should be upgraded because it's providing contant time tooling, but if dalek felt no need to upgrade yet, then we're fine too. |
|
Don't forget to publish 0.11.4 with this so we can use it on polkadot :) |
|
Done |
|
We'll probably have more mess from dalek-cryptography/subtle#118 in future |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is to help with paritytech/polkadot-sdk#2524 (comment). If you agree with this change and merge it please release schnorrkel 0.11.4 afterwards.