Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Wagtail 6.1 - Minor updates #91

Merged
merged 4 commits into from
May 24, 2024
Merged

Conversation

@nickmoreton
Copy link
Contributor

nickmoreton commented May 21, 2024

Hi @katdom13 I think it might be a good time to overhaul some testing dependencies. I tried this locally in setup.py

docs_require = [
    "sphinx==7.1.2",
]

tests_require = [
    "pytest==8.2.1",
    "pytest-django==4.8.0",
    "pytest-cov==5.0.0",
    "pytest-pythonpath==0.7.3",
    "coverage==7.5.1",
    "ruff==0.4.4",
]

The docs seemed to build OK but there was a configuration warning that might need attention.

The tests might fail but there's some clues about that here: #89

- name: Install build requirements
run: python -m pip install wheel
- name: Build package
run: python setup.py sdist bdist_wheel
- name: Publish package
uses: pypa/gh-action-pypi-publish@master
uses: pypa/gh-action-pypi-publish@release/v1
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Will throw an error if published and if the Pypi user has no verified email address.
@kevinhowbrook

@katdom13
Copy link
Contributor Author

katdom13 commented May 22, 2024

Hi @katdom13 I think it might be a good time to overhaul some testing dependencies. I tried this locally in setup.py

docs_require = [
    "sphinx==7.1.2",
]

tests_require = [
    "pytest==8.2.1",
    "pytest-django==4.8.0",
    "pytest-cov==5.0.0",
    "pytest-pythonpath==0.7.3",
    "coverage==7.5.1",
    "ruff==0.4.4",
]

The docs seemed to build OK but there was a configuration warning that might need attention.

The tests might fail but there's some clues about that here: #89

Hi @nickmoreton ,
Thanks, I've updated those in one of the newest commits. I also updated the workflows, but I know this will throw an error on publish. I left a comment as to why:
#91 (comment)

Copy link
Contributor

@nickmoreton nickmoreton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @katdom13 Looks good.

@jams2 jams2 merged commit 9765818 into wagtail:main May 24, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants