Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: upgrade to libp2p v2 #2143

Merged
merged 14 commits into from
Oct 21, 2024
Merged

chore: upgrade to libp2p v2 #2143

merged 14 commits into from
Oct 21, 2024

Conversation

danisharora099
Copy link
Collaborator

@github-actions GitHub Actions
Copy link

github-actions bot commented Sep 19, 2024 •
edited
Loading

size-limit report 📦

Path Size Loading time (3g) Running time (snapdragon) Total time
Waku node 86.4 KB (+0.66% 🔺) 1.8 s (+0.66% 🔺) 13 s (-10.52% 🔽) 14.7 s
Waku Simple Light Node 136.95 KB (-0.49% 🔽) 2.8 s (-0.49% 🔽) 18.7 s (+39.36% 🔺) 21.4 s
ECIES encryption 22.88 KB (0%) 458 ms (0%) 7.5 s (+96.1% 🔺) 7.9 s
Symmetric encryption 22.37 KB (0%) 448 ms (0%) 4.9 s (+87.42% 🔺) 5.4 s
DNS discovery 70.6 KB (-3.15% 🔽) 1.5 s (-3.15% 🔽) 10.3 s (-22.69% 🔽) 11.7 s
Peer Exchange discovery 71.84 KB (-3.05% 🔽) 1.5 s (-3.05% 🔽) 15.8 s (+4.56% 🔺) 17.2 s
Local Peer Cache Discovery 65.17 KB (-4.22% 🔽) 1.4 s (-4.22% 🔽) 13.8 s (+13.67% 🔺) 15.1 s
Privacy preserving protocols 75.98 KB (-0.05% 🔽) 1.6 s (-0.05% 🔽) 10.4 s (-11.58% 🔽) 11.9 s
Waku Filter 80.95 KB (+0.8% 🔺) 1.7 s (+0.8% 🔺) 9.3 s (-12.21% 🔽) 10.9 s
Waku LightPush 75.68 KB (+0.87% 🔺) 1.6 s (+0.87% 🔺) 13.6 s (+19.53% 🔺) 15.1 s
History retrieval protocols 77.71 KB (+0.89% 🔺) 1.6 s (+0.89% 🔺) 10.3 s (-15.88% 🔽) 11.8 s
Deterministic Message Hashing 7.39 KB (0%) 148 ms (0%) 1.3 s (-52.82% 🔽) 1.4 s

@danisharora099 danisharora099 marked this pull request as ready for review September 27, 2024 12:52
@danisharora099 danisharora099 requested a review from a team as a code owner September 27, 2024 12:52
@danisharora099 danisharora099 force-pushed the chore/libp2p-v2 branch 2 times, most recently from a1c3f08 to 7c5382f Compare October 8, 2024 07:15
@danisharora099 danisharora099 mentioned this pull request Oct 8, 2024
Closed
@weboko
Copy link
Collaborator

weboko commented Oct 8, 2024 •
edited
Loading

Have no questions to the PR, we definitely need to upgrade libp2p.
But let's postpone till #2135 is merged.

It is risky to include into next release without proper dogfooding and we have some projects requiring #2137 and #2158

@danisharora099 danisharora099 mentioned this pull request Oct 10, 2024
Closed
@danisharora099 danisharora099 force-pushed the chore/libp2p-v2 branch 2 times, most recently from 22b146c to 2b372ce Compare October 10, 2024 10:20
@danisharora099
Copy link
Collaborator Author

It is risky to include into next release without proper dogfooding and we have some projects requiring #2137 and #2158

Tests passing, PR is ready. There shouldn't be anything to dogfood with this internal upgrade, especially considering all tests now pass.

Merging it would also resolve #2174 @weboko

@weboko
Copy link
Collaborator

weboko commented Oct 10, 2024

@danisharora099 did you try dogfooding it? I haven't but I'd like to have it done in various contexts before we merge

Contexts to check:

  • how long and good light push functions
  • is there any problems with outbound / inbound streams and connections
  • are events propagating the same way we expect them: peer connect and disconnect, identify
  • etc

Let's do this on Monday and if nothing caught - we can merge.

@danisharora099 danisharora099 force-pushed the chore/libp2p-v2 branch 4 times, most recently from 5cd0bab to f316ea7 Compare October 16, 2024 12:27
@danisharora099 danisharora099 requested a review from weboko October 17, 2024 07:14
weboko
weboko reviewed Oct 17, 2024
View reviewed changes
packages/sdk/src/create/libp2p.ts
transports: [webSockets({ filter: filter })],
streamMuxers: [mplex()],
connectionEncryption: [noise()],
connectionEncrypters: [noise()],
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

that's interesting breaking change :D

weboko
weboko approved these changes Oct 17, 2024
View reviewed changes
Copy link
Collaborator

@weboko weboko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

left some small comments

@danisharora099 danisharora099 merged commit 7c0ce7b into master Oct 21, 2024
10 of 11 checks passed
@danisharora099 danisharora099 deleted the chore/libp2p-v2 branch October 21, 2024 11:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@weboko weboko weboko approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@danisharora099 @weboko