feat(store): allow using a specific node #2192
Conversation
size-limit report 📦
|
| let peerIdStr: PeerIdStr | undefined; | ||
| if (options.store?.peer) { | ||
| this.connectionManager | ||
| .dialPeer(options.store.peer, [StoreCodec]) |
There was a problem hiding this comment.
let's not introduce this function and use
js-waku/packages/sdk/src/waku/waku.ts
Line 143 in 88e33a9
which does the same as I see
There was a problem hiding this comment.
good point - now that we have a dial function in the ConnectionManager, we should be proxying dials through that.
instead of doing libp2p.dial() on the Waku object, proxied it through the ConnectionManager.dialPeer() function: 7ad9acc
This also help clean up the string type for multiaddr as ConnectionManager.dialPeer() is now compliant with the MultiaddrInput type
packages/tests/tests/connection-mananger/connection_state.spec.ts
Outdated
Show resolved
Hide resolved
| return peer; | ||
| } else { | ||
| // peer is of MultiaddrInput type | ||
| const ma = multiaddr(peer); |
There was a problem hiding this comment.
yes, the class implementation can throw in several cases, mostly parsing of the multiaddr passed to it; why do you ask?
danisharora099
force-pushed
the
feat/specific-node
branch
from
060e316 to
6b452a5
Compare
Problem
Users need the ability to specify the peers used for their apps, for different protocols. Specifically for Store: https://discord.com/channels/1110799176264056863/1290694275683582085/1291644836742565929
Solution
Provides the ability to pass a specific node multiaddr while node creation to be used for Store. Falls back to random nodes if not passed.
Notes
Contribution checklist:
!in title if breaks public API;