feat(store): allow using a specific node #2192
Open
+84
−14
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
size-limit report 📦
|
weboko
reviewed
Oct 29, 2024
weboko
reviewed
Oct 29, 2024
weboko
reviewed
Oct 29, 2024
weboko
reviewed
Dec 16, 2024
weboko
reviewed
Dec 16, 2024
| @@ -11,6 +13,7 @@ import { | |||
| IPeersByDiscoveryEvents, | |||
| IRelay, | |||
| KeepAliveOptions, | |||
| MultiaddrStr, | |||
There was a problem hiding this comment.
there should be a type for it in multiaddr package
weboko
reviewed
Dec 16, 2024
| @@ -28,6 +28,10 @@ export type IBaseProtocolSDK = { | |||
| readonly numPeersToUse: number; | |||
| }; | |||
|
|
|||
| type StoreProtocolOptions = { | |||
| peer: string; | |||
There was a problem hiding this comment.
Let's make it peers in the following PR
There was a problem hiding this comment.
We only use one peer for Store, unlike LightPush and Filter. When use getPeers() within Store, we still only use the 0th index from the array of peers returned.
peers: string[] would be applicable to LightPush and Filter
weboko
reviewed
Dec 16, 2024
weboko
reviewed
Dec 16, 2024
packages/sdk/src/waku/waku.ts
Outdated
| }); | ||
| } | ||
|
|
||
| const store = wakuStore(this.connectionManager, peerIdStr); |
There was a problem hiding this comment.
this is wrong, peerIdStr does nothing here
There was a problem hiding this comment.
It is used to initialise Store with the protocol to use since we need to get the peer when we send a store request. Changed the peerIdStrToUse to options: Partial<StoreProtocolOptions>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
Users need the ability to specify the peers used for their apps, for different protocols. Specifically for Store: https://discord.com/channels/1110799176264056863/1290694275683582085/1291644836742565929
Solution
Provides the ability to pass a specific node multiaddr while node creation to be used for Store. Falls back to random nodes if not passed.
Notes
Contribution checklist:
!in title if breaks public API;